app icon indicating copy to clipboard operation
app copied to clipboard

Formalize same UI for 'inventory' and 'From upstreet' items

Open mavisakalyan opened this issue 2 years ago • 4 comments

Describe your changes

  • made both lists in the inventory and upstream to look the same have similar structure so we are consistent with the design. Only difference is the highlight.

What are the steps for a QA tester to test this pull request?

  • find some items to add to your claims list and check both lists, inventory and from upstream in the account tab. Both lists should be the same in structure with color differance.

Issue ticket number and link

https://github.com/webaverse/app/issues/3388

Screenshots and/or video

Screen Shot 2022-08-09 at 19 51 06 Screen Shot 2022-08-09 at 19 51 16

Checklist before requesting a review

  • [x] I have performed a self-review of my code
  • [x] I am not adding any irrelevant code or assets
  • [x] I am only including the changes needed to implement the change
  • [x] I have playtested and intentionally tried to find error cases but couldn't

mavisakalyan avatar Aug 09 '22 15:08 mavisakalyan

The orange highlight was not intended as an actual design.

We can do a lot better with e.g. circle border, curved box icons in the corner, or background gradients to indicate categories. The only reason the inventory page is like this is it's something I did in 5 minutes a year ago.

avaer avatar Aug 10 '22 00:08 avaer

Got it let me see what I can come up with.

mavisakalyan avatar Aug 10 '22 10:08 mavisakalyan

One question though, should the hover effect be different in color for different tabs? or should we keep one consistent design? @avaer

mavisakalyan avatar Aug 10 '22 10:08 mavisakalyan

@mavisakalyan don't worry about hover for now

lalalune avatar Aug 12 '22 19:08 lalalune