app
app copied to clipboard
webaverse
Add cryptoavatars
Describe your changes
- Crypto avatars list added to the character select box.
- Character select preview box fixed to the bottom so when you scroll through all the lists it does not scroll with it.
- Changed the show arrow on hover for selecting the characters to just css and removed updateArrowPosition to decrease FPS ( No need to run all those functions for just 1 arrow ).
- Fixed the issue where some characters were facing the other way on preview.
- Fixed the app crashing when certain characters were selected ( problem was that not all models have the Head mesh called exactly "Head" so we modified the code a bit. )
- Styled the select boxes for the CryptoAvatar menu to fit the design better.
What are the steps for a QA tester to test this pull request?
- Load the scene
- Open the character select menu
- And surf through the newly added CryptoAvatar characters
- Use pagination, hover over the characters and see them in the preview box
- Select the characters and playtest.
Issue ticket number and link
Screenshots and/or video
https://user-images.githubusercontent.com/55106546/183263052-12afeccf-24db-45a5-b3d6-e2638aeccb66.mov
Checklist before requesting a review
- [x] I have performed a self-review of my code
- [x] I am not adding any irrelevant code or assets
- [x] I am only including the changes needed to implement the change
- [x] I have playtested and intentionally tried to find error cases but couldn't
Can we get rid of PNG and use SVG?
https://github.com/webaverse/app/pull/3528/files#diff-94bce46600a509ecd3a2f8c05432084ba0e40346ff825454501753c45efdcd8c
Code can’t be trusted since it included irrelevant security related files like package-lock.json contrary to the misleading description.
If this is going to be merged it needs a total redo without security problems in the history.
Issues: 1-The premium avatars are accessible while they shouldn't be:
https://user-images.githubusercontent.com/111510128/188887493-d3f32639-9040-4663-a9ae-eb8c2fe48b33.mp4
2-The previews are going out of bounds of preview area:
https://user-images.githubusercontent.com/111510128/188887949-874a6363-4193-4e17-a737-60ae5f68a2cd.mp4
3-Selecting the options isn't working as expected. For example: choosing the ownership as free use or owned throws these errors, meanwhile the characters in list remain the same.
https://user-images.githubusercontent.com/111510128/188888988-4ee8e666-9fb1-4b43-8896-f3b867549288.mp4
4-Selecting the 25 avatars per page option only gets 20 avatars instead of 25:
5-If we select 10, 25 characters per page, the characters appear above the preview of the selected character. Can we fix it so that preview isn't covered?
6-When we have the openai key set up, some of the characters play the same intro as we have for above upstreet avatars:
https://user-images.githubusercontent.com/111510128/188890441-d934ebe7-20ad-421d-baf5-2296bfa4f5d8.mp4
Hi, i am going to update this PR with the new nft collection system of our API and fix the problem with premium avatars wich can be selected.
Hi, i am going to update this PR with the new nft collection system of our API and fix the problem with premium avatars wich can be selected.
Great. We have the same work earmarked, if you can get to it first, great.
We have this merged and in testing over at: https://github.com/webaverse-studios/app
This is kind of our staging server atm
Gonna close this PR in place of the one we have their.
Hi, i am going to update this PR with the new nft collection system of our API and fix the problem with premium avatars wich can be selected.
Great. We have the same work earmarked, if you can get to it first, great.
We have this merged and in testing over at: https://github.com/webaverse-studios/app
This is kind of our staging server atm
Gonna close this PR in place of the one we have their.