webark
Component name lookup failing
this 99% fixes #335, without "unique paths". This is to provide a stop gap until the "js for every component" solution is provided
https://github.com/ebryn/ember-component-css/blob/aa2ce7a5aeea65fefef7d5096dda4a051e8ce3a6/addon/utils/add-component-style-namespace.js#L2-L21
This is how i’m handling the this in the “new world order” btw
Edit:: well, i mean the general intent would be to import the class name and apply it directly, but this was intended as the “catch all” to ease adoption. (except this doesn’t work for addon components that are not re exported into the “app” space)
Sorry, i'm not sure if I haven't had enough coffee or if I'm having tunnel vision...but what is the organizational change you wont me to make? 😪
@tylerturdenpants something like..
function identifierFromLayoutModuleName(modulePath = '') {
const terminator = 'components/';
const pathSegementToRemove = /.+\/components\//;
return modulePath.replace(/\.\w+$/, '')
.substr(modulePath.lastIndexOf(terminator) + terminator.length)
.replace(pathSegementToRemove, '')
.replace(/\/template/, '');
}
function identifierFromDebugContainerKey(debugContainerKey = '') {
return debugContainerKey.replace('component:', '');
}
Component.reopen({
_componentIdentifier: computed({
get() {
return identifierFromLayoutModuleName(this.get('layout.referrer.moduleName') || identifierFromDebugContainerKey(this._debugContainerKey);
}
}),
...
styleNamespace: computed({
get() {
return podNames[this.get('_componentIdentifier')] || '';
}
}),
...
});
I got a little confused by the other things that you were talking about. But here you go!
@webark if you could clear the CI cache that would be awesome. The core-js authors had a package foobar - https://github.com/zloirock/core-js/issues/710
@webark so Travis is still acting funky. The builds will pass but all caches need to be cleared and the CI restarted. I face similar issues with my own projects. I’d fix this but I can’t do anything and Travis to fix it. Let me know if you need anything else. I know there will be a lot of happy people once this lands.
I don’t love the skipped test that was introduced. I’ll look into this tomorrow, and then merge it either way.
The skipped test was to start a dialogue on wether to support paths that are non-standard or fall under MU. This approach only works if non-standard paths are not used - I think this usage is likely so low it’s not worth carrying through to a 1.0 release (my opinion 😝 ). I had to make similar concessions while working on the angle-bracket codemod
Did you get a chance to review?
On Mon, Dec 2, 2019 at 7:57 PM Mark Avery [email protected] wrote:
thanks so much for this!!!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ebryn/ember-component-css/pull/339?email_source=notifications&email_token=AEK3PR5U2ALN2TXNWBBOQATQWXKLHA5CNFSM4JTDKFC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFX733A#issuecomment-560987628, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEK3PR7A5ZIP5MMKLSKNNSTQWXKLHANCNFSM4JTDKFCQ .
If i am unable today, i’ll just release this as a beta until i have a chance to look into the unsupported paths.
No worries. A beta will great. If you need anything more from me, let me know. I’m curious about the use case for unsupported paths (and supporting them). If you can point me to any documentation, blog, RFC, etc about unsupported paths so that I can get more insight about them I’d really appreciate it.
https://github.com/ebryn/ember-component-css/pull/238
and the corresponding issue have examples.
thanks! Now that I have some concrete background on this usage, I think I can look into finding a fix alongside you.
@NullVoxPopuli as you can see I borrowed logic from telemetry helpers to inspect the module and it’s path. I think this might be the only way to identify the component name by applying some heuristic to the module name. Do you know how we could do that with component co-location? I imagine it should be straight forward.
@tylerturdenpants are you still using this addon? or have you moved off of it due to this issue? Just finally coming back around to these.
@webark yes very much so. We are blocked on upgrading past 3.12. The team at work has double in size and this is the de-facto way that we style and probably why we haven’t moved on to another addon. I willing to help where you need me.