Mark Avery

Results 296 comments of Mark Avery

spent some time over the weekend getting up to speed with the current state of things, and this PR. Need one more weekend to iron everything out. Will have this...

Template only components have no solution with this iteration. The solution has been to add a "styleNamespace" local variable or helper which can be used to add the namespace where...

If we could get that test passed for at least the "unique component paths" test, I'd be fine merging it. I left a comment on what I think is the...

@rwwagner90 so for glimmer components, what I have so far, and I'm open to ideas, is what I'm doing is wrapping every template in a let block that adds a...

@rwwagner90 yea, this is what I'm doing.. https://github.com/ebryn/ember-component-css/blob/60f261f99797864ae5bd730d6d5799dc7a95cac0/lib/scope-templates.js#L15-L19 so it will still be there.

@adambedford yea. I would suggest just always using styleNamespace without the this. It will have to get added as a global for the template lint. If prefer to have it...

@SergeAstapov for the template stuff, this uses a template ast transform. I considered doing that. We could add a fake helper of `style-namespace` that just gets switched out at build....

i guess we could have the ast do the let part and pass in the `(this.styleNamespace or "styleNamespace")` .. hmm.. that's actually not a terrible idea. I might look into.

might give us the best of both worlds. Handlebars AST's are annoying though.. I might work though that. you'd have to catch the different uses for it.. like it it...

@boris-petrov i'm not sure it would be a performance hit, but i agree with the sentiment. It's not ideal, but it's predictable.. I wish every there was an actual story...