web3swift icon indicating copy to clipboard operation
web3swift copied to clipboard

change minimum version of CryptoSwift dependency to 1.8.0

Open g1umov opened this issue 1 year ago • 3 comments

What context is your feature request related to?

There is an dependencies resolving issue within SPM package in my iOS project. For example, try to add 'SwiftLint' and 'web3swift' dependencies into a package and you will see the following error message:

'Failed to resolve dependencies Dependencies could not be resolved because 'core' depends on 'swiftlint' 0.54.0..<1.0.0 and 'core' depends on 'web3swift' 3.2.0..<4.0.0. 'web3swift' is incompatible with 'swiftlint' because 'swiftlint' 0.54.0 depends on 'cryptoswift' 1.8.0..<1.9.0 and no versions of 'swiftlint' match the requirement 0.54.1..<1.0.0. 'web3swift' >= 3.2.0 practically depends on 'cryptoswift' 1.5.1..<1.6.0 because no versions of 'web3swift' match the requirement 3.2.1..<4.0.0 and 'web3swift' 3.2.0 depends on 'cryptoswift' 1.5.1..<1.6.0.'

What solution would you like?

I suggest to change min version of the 'CryptoSwift' dependency to 1.8.0

Any additional context?

No response

g1umov avatar Feb 10 '24 22:02 g1umov

Hi, thanks for an issue and the PR for the project. Just wonder what is the purpose of including SwiftLint dependency in your app?

yaroslavyaroslav avatar Feb 11 '24 10:02 yaroslavyaroslav

Hi, I use the SwiftLint dependency as a plugin for some targets in the package.

g1umov avatar Feb 11 '24 11:02 g1umov

Yeah, seems legit. Although this given fix fixes the issue, I'm worried that it's so until the next swiftlint & crypto swift update, which is not ok in general.

@JeneaVranceanu have we considered to drop this dependency in the past?

yaroslavyaroslav avatar Feb 11 '24 16:02 yaroslavyaroslav