web3swift icon indicating copy to clipboard operation
web3swift copied to clipboard

Minor: description of transaction doesn't return `from`

Open janndriessen opened this issue 2 years ago • 1 comments

What piece of the framework are having the lack of docs?

The from field on transaction is not returned as expected when calling a description on a transaction.

To reproduct:

  • Call description on a transaction that has the from field set.

You can see here that the issue that only sender is return as from when set: https://github.com/web3swift-team/web3swift/blob/develop/Sources/Web3Core/Transaction/CodableTransaction.swift#L274

What bit of docs would you like to have?

In general whoever takes this ticket could look at improving the description of a transaction.

janndriessen avatar Feb 09 '23 08:02 janndriessen

PR #783 opened @janndriessen Could you take a look? If the purpose was wrongly understood let me know :)

albertopeam avatar Feb 20 '23 21:02 albertopeam