ReadOperation handle FIXME
What context is your feature request related to?
Handle this fixme in ReadOperation. // FIXME: Rewrite this to CodableTransaction
What solution would you like?
Remove the FIXME and provide a long term solution
Any additional context?
- Ask @yaroslavyaroslav as he left the FIXME, we need some context about what is his original idea
- Then we need some time to provide a solution
@yaroslavyaroslav I would like to understand what is your idea about this FIXME. I will be reading the code and figure out what can I purpose as a solution from my point of view
I have checking and WriteOperation inherits ReadOperation and has a FIXME FIXME: Rewrite this to CodableTransaction.
We should apply same/similar strategy
To be honest I don't get the point of moving ReadOperation to CodableTransaction.
This Read/Write is highly coupled with the contract itself not a transaction(If I am wrong let me know)
What I can see right now is that it could be nice to:
- protocolize ReadOperation and make the implementation internal
- protocolize WriteOperation, make the implementation internal and remove inheritance from ReadOperation
Please, provide some insights from your point of view @yaroslavyaroslav :)
@albertopeam it was a self notes that I've made in sake of convenience while developing 3.0.0 so it's all deprecated for now and should be deleted from code.
ok, then it should be enough to do points 1 and 2? @yaroslavyaroslav
@albertopeam not sure if I've got your last message, but anyway, my point was that the desired solution for those fixme is just to delete them from the code 💁🏻♂️. Like it's all done priori 3.0.0 release and was addressed to merging different types of transaction types that library had has back there.