web3swift icon indicating copy to clipboard operation
web3swift copied to clipboard

Published 20 hours ago • verified publisher icon web3swift-team

[WIP] fix: EIP681 parsing query parameters with extra whitespace characters

Open JeneaVranceanu opened this issue 2 years ago • 1 comments

What was introduced?

  1. Corrected parsing of query parameters of EIP681 URL if that parameter is an array and contains whitespace characters between elements, e.g. ethereum:0x5ffc...4cc4/functionName?bytes2[]=[0xFFFF, 0x0551 , 0x2200,0x1212]. White space between items and separators resulted in incorrect decoding.
  2. Added encoding of value, gasLimit, gasPrice into the EIP681 when calling makeEIP681Link() -> String?. Example: ethereum:0x5ffc...4cc4?value=77445123&gasLimit=1234&gasPrice=789456

JeneaVranceanu avatar Aug 25 '22 09:08 JeneaVranceanu

@JeneaVranceanu Is this PR ready to be merged?

yaroslavyaroslav avatar Sep 20 '22 07:09 yaroslavyaroslav