web3swift icon indicating copy to clipboard operation
web3swift copied to clipboard

chore: EthereumBloomFilter improvement

Open JeneaVranceanu opened this issue 2 years ago • 3 comments

Added docs, structured code a bit better, some refactoring with at least 10% improvement in the calculation of a filter.

This PR contains refactoring of bloom9 function.

The rest is just renaming a file, reordering of functions, documentation and one performance test.

JeneaVranceanu avatar Aug 11 '22 14:08 JeneaVranceanu

Thank you, I'll merge it soon, after meeting my huge PR that merges all different transaction types into one.

yaroslavyaroslav avatar Sep 02 '22 08:09 yaroslavyaroslav

@JeneaVranceanu Sorry I've broke your PR, could you please update it?

yaroslavyaroslav avatar Sep 20 '22 07:09 yaroslavyaroslav

@JeneaVranceanu Sorry I've broke your PR, could you please update it?

@yaroslavyaroslav Sure, no worries!

JeneaVranceanu avatar Sep 22 '22 12:09 JeneaVranceanu

@yaroslavyaroslav Conflicts fixed.

JeneaVranceanu avatar Sep 27 '22 11:09 JeneaVranceanu