web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

update typescript version to 5

Open Muhammad-Altabba opened this issue 1 year ago • 2 comments
trafficstars

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run lint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:unit with success.
  • [ ] I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build and tested dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.
  • [ ] I have linked Issue(s) with this PR in "Linked Issues" menu.

Muhammad-Altabba avatar Sep 19 '24 20:09 Muhammad-Altabba

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 648.95 kB → 646.32 kB (-2.63 kB) -0.40%
Changeset
File Δ Size
../web3-eth/lib/commonjs/utils/try_send_transaction.js 📈 +74 B (+2.76%) 2.62 kB → 2.69 kB
../web3-eth/lib/commonjs/utils/reject_if_block_timeout.js 📈 +129 B (+1.79%) 7.04 kB → 7.17 kB
../web3-eth/lib/commonjs/utils/prepare_transaction_for_signing.js 📈 +102 B (+1.46%) 6.84 kB → 6.94 kB
../web3-eth/lib/commonjs/utils/transaction_builder.js 📈 +123 B (+1.17%) 10.22 kB → 10.34 kB
../web3-eth-accounts/lib/commonjs/tx/eip2930Transaction.js 📈 +159 B (+1.11%) 13.94 kB → 14.09 kB
../web3-eth/lib/commonjs/utils/decoding.js 📈 +35 B (+1.06%) 3.22 kB → 3.25 kB
../web3-core/lib/commonjs/web3_subscription_manager.js 📈 +94 B (+1.05%) 8.75 kB → 8.85 kB
../web3-eth-accounts/lib/commonjs/tx/eip1559Transaction.js 📈 +159 B (+1.04%) 15 kB → 15.16 kB
../web3-errors/lib/commonjs/errors/contract_errors.js 📈 +81 B (+0.99%) 7.98 kB → 8.06 kB
../web3-eth-abi/lib/commonjs/utils.js 📈 +77 B (+0.82%) 9.19 kB → 9.26 kB
../web3-eth-accounts/lib/commonjs/tx/baseTransaction.js 📈 +134 B (+0.73%) 18 kB → 18.13 kB
../web3-eth/lib/commonjs/web3_eth.js 📈 +690 B (+0.66%) 101.38 kB → 102.05 kB
../web3-eth-contract/lib/commonjs/contract-subscription-manager.js 📈 +17 B (+0.53%) 3.16 kB → 3.18 kB
src/web3.ts 📈 +45 B (+0.52%) 8.48 kB → 8.53 kB
../web3-eth-ens/lib/commonjs/resolver.js 📈 +32 B (+0.49%) 6.36 kB → 6.39 kB
../web3-eth/lib/commonjs/utils/wait_for_transaction_receipt.js 📈 +19 B (+0.48%) 3.87 kB → 3.89 kB
../web3-eth/lib/commonjs/utils/get_revert_reason.js 📈 +20 B (+0.46%) 4.26 kB → 4.28 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +32 B (+0.34%) 9.09 kB → 9.12 kB
../web3-eth-ens/lib/commonjs/ens.js 📈 +24 B (+0.21%) 11.4 kB → 11.42 kB
../web3-utils/lib/commonjs/web3_eip1193_provider.js 📈 +8 B (+0.18%) 4.42 kB → 4.43 kB
../web3-eth-contract/lib/commonjs/contract-deployer-method-class.js 📈 +12 B (+0.17%) 6.95 kB → 6.96 kB
../web3-eth-accounts/lib/commonjs/common/common.js 📈 +78 B (+0.17%) 45.52 kB → 45.59 kB
../web3-core/lib/commonjs/web3_batch_request.js 📈 +8 B (+0.16%) 4.95 kB → 4.96 kB
../web3-eth-accounts/lib/commonjs/common/utils.js 📈 +30 B (+0.14%) 20.43 kB → 20.46 kB
../web3-net/lib/commonjs/net.js 📈 +6 B (+0.12%) 4.8 kB → 4.81 kB
../web3-utils/lib/commonjs/socket_provider.js 📈 +17 B (+0.12%) 13.98 kB → 14 kB
../web3-providers-http/lib/commonjs/index.js 📈 +4 B (+0.09%) 4.43 kB → 4.43 kB
../web3-core/lib/commonjs/web3_config.js 📉 -8 B (-0.04%) 17.44 kB → 17.43 kB
../web3-core/lib/commonjs/web3_request_manager.js 📉 -8 B (-0.05%) 16.21 kB → 16.2 kB
src/web3_eip6963.ts 📉 -6 B (-0.19%) 3.08 kB → 3.08 kB
../web3-eth-contract/lib/commonjs/contract.js 📉 -98 B (-0.23%) 42.05 kB → 41.95 kB
../web3-rpc-providers/lib/commonjs/types.js 📉 -16 B (-0.42%) 3.75 kB → 3.73 kB
../web3-utils/lib/commonjs/validation.js 📉 -28 B (-0.45%) 6.05 kB → 6.03 kB
../web3-eth/lib/commonjs/rpc_method_wrappers.js 📉 -201 B (-0.46%) 42.44 kB → 42.25 kB
../web3-validator/lib/commonjs/utils.js 📉 -87 B (-0.54%) 15.81 kB → 15.72 kB
../web3-eth/lib/commonjs/utils/get_transaction_gas_pricing.js 📉 -39 B (-0.77%) 4.93 kB → 4.89 kB
../web3-types/lib/commonjs/eth_types.js 📉 -16 B (-0.93%) 1.68 kB → 1.67 kB
../web3-eth-accounts/lib/commonjs/common/enums.js 📉 -40 B (-0.98%) 3.98 kB → 3.94 kB
../web3-types/lib/commonjs/data_format_types.js 📉 -16 B (-1.06%) 1.48 kB → 1.46 kB
../web3-eth/lib/commonjs/utils/get_transaction_error.js 📉 -38 B (-1.09%) 3.41 kB → 3.37 kB
../web3-eth-abi/lib/commonjs/coders/base/tuple.js 📉 -52 B (-1.10%) 4.63 kB → 4.58 kB
../web3-eth/lib/commonjs/utils/format_transaction.js 📉 -36 B (-1.11%) 3.17 kB → 3.13 kB
../web3-rpc-providers/lib/commonjs/web3_provider.js 📉 -66 B (-1.16%) 5.55 kB → 5.49 kB
../web3-eth-abi/lib/commonjs/coders/base/array.js 📉 -52 B (-1.17%) 4.33 kB → 4.28 kB
../web3-validator/lib/commonjs/validation/string.js 📉 -46 B (-1.28%) 3.52 kB → 3.47 kB
../web3-eth-abi/lib/commonjs/coders/base/number.js 📉 -54 B (-1.28%) 4.12 kB → 4.07 kB
../web3-eth-abi/lib/commonjs/coders/base/bytes.js 📉 -52 B (-1.34%) 3.79 kB → 3.74 kB
../web3-eth-abi/lib/commonjs/coders/base/index.js 📉 -76 B (-1.35%) 5.49 kB → 5.42 kB
../web3-eth-abi/lib/commonjs/coders/encode.js 📉 -75 B (-1.52%) 4.81 kB → 4.74 kB
../web3-net/lib/commonjs/rpc_method_wrappers.js 📉 -39 B (-1.53%) 2.49 kB → 2.45 kB
../web3-eth-accounts/lib/commonjs/common/types.js 📉 -8 B (-1.54%) 519 B → 511 B
../web3-eth/lib/commonjs/utils/watch_transaction_for_confirmations.js 📉 -51 B (-1.79%) 2.78 kB → 2.73 kB
../web3-eth-contract/lib/commonjs/contract_log_subscription.js 📉 -74 B (-1.86%) 3.89 kB → 3.82 kB
../web3-eth-abi/lib/commonjs/coders/base/address.js 📉 -56 B (-1.90%) 2.89 kB → 2.83 kB
../web3-eth-abi/lib/commonjs/coders/base/utils.js 📉 -38 B (-1.99%) 1.87 kB → 1.83 kB
../web3-eth/lib/commonjs/utils/decode_signed_transaction.js 📉 -42 B (-2.31%) 1.78 kB → 1.74 kB
../web3-eth/lib/commonjs/validation.js 📉 -325 B (-2.37%) 13.38 kB → 13.06 kB
../web3-eth/lib/commonjs/filtering_rpc_method_wrappers.js 📉 -186 B (-2.49%) 7.3 kB → 7.12 kB
../web3-eth-abi/lib/commonjs/coders/base/bool.js 📉 -53 B (-2.52%) 2.05 kB → 2 kB
../web3-utils/lib/commonjs/promise_helpers.js 📉 -189 B (-2.70%) 6.83 kB → 6.65 kB
../web3-eth-abi/lib/commonjs/coders/decode.js 📉 -35 B (-2.74%) 1.25 kB → 1.21 kB
../web3-eth-abi/lib/commonjs/coders/base/string.js 📉 -54 B (-3.41%) 1.55 kB → 1.49 kB
../web3-eth-abi/lib/commonjs/coders/utils.js 📉 -170 B (-3.49%) 4.75 kB → 4.59 kB
../web3-eth-accounts/lib/commonjs/tx/types.js 📉 -64 B (-3.58%) 1.75 kB → 1.69 kB
../web3-eth-accounts/lib/commonjs/tx/utils.js 📉 -215 B (-3.77%) 5.57 kB → 5.36 kB
../web3-utils/lib/commonjs/uint8array.js 📉 -85 B (-4.12%) 2.01 kB → 1.93 kB
../web3-rpc-methods/lib/commonjs/net_rpc_methods.js 📉 -69 B (-4.29%) 1.57 kB → 1.5 kB
../web3-rpc-methods/lib/commonjs/eth_rpc_methods.js 📉 -1.35 kB (-6.38%) 21.22 kB → 19.86 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
../lib/commonjs/accounts.d.ts 3.06 kB → 3.19 kB (+128 B) +4.08%
../lib/commonjs/abi.d.ts 1.06 kB → 1.14 kB (+81 B) +7.44%

Smaller

Asset File Size % Changed
web3.min.js 630.19 kB → 627.37 kB (-2.82 kB) -0.45%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB → 1.27 kB (-8 B) -0.61%

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/types.d.ts 2.73 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

github-actions[bot] avatar Sep 19 '24 20:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (56d4aec) to head (32ad76e). Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7272      +/-   ##
==========================================
+ Coverage   94.51%   94.54%   +0.02%     
==========================================
  Files         218      218              
  Lines        8557     8637      +80     
  Branches     2364     2364              
==========================================
+ Hits         8088     8166      +78     
- Misses        469      471       +2     
Flag Coverage Δ
UnitTests 94.54% <97.56%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

codecov[bot] avatar Sep 23 '24 13:09 codecov[bot]

As discussed dev release from this PR needs to be tested with a plugin.

jdevcs avatar Nov 06 '24 09:11 jdevcs