web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

[DFAFT] run `yarn format` and apply correct local config for auto format on save.

Open Muhammad-Altabba opened this issue 1 year ago • 2 comments

Description

Fixes #7186

The current MR applies: run yarn format.

However, someone still needs to check for the formatting configurations to apply it locally correctly so we have the correct formatting on save.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run lint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:unit with success.
  • [ ] I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build and tested dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.
  • [ ] I have linked Issue(s) with this PR in "Linked Issues" menu.

Muhammad-Altabba avatar Aug 05 '24 07:08 Muhammad-Altabba

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 636.44 kB 0%
Changeset
File Δ Size
../web3-rpc-providers/lib/commonjs/web3_provider_quicknode.js 📈 +80 B (+2.00%) 3.9 kB → 3.98 kB
../web3-rpc-providers/lib/commonjs/web3_provider.js 📈 +100 B (+1.91%) 5.13 kB → 5.22 kB
../web3-validator/lib/commonjs/validation/bytes.js 📈 +24 B (+0.86%) 2.73 kB → 2.76 kB
../web3-validator/lib/commonjs/validator.js 📈 +36 B (+0.49%) 7.11 kB → 7.15 kB
../web3-core/lib/commonjs/utils.js 📈 +8 B (+0.27%) 2.85 kB → 2.85 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +20 B (+0.22%) 9.01 kB → 9.03 kB
../web3-eth-personal/lib/commonjs/personal.js 📈 +19 B (+0.15%) 11.99 kB → 12.01 kB
../web3-eth/lib/commonjs/rpc_method_wrappers.js 📈 +46 B (+0.11%) 41.64 kB → 41.69 kB
../web3-eth-abi/lib/commonjs/coders/base/numbersLimits.js 📈 +1 B (+0.06%) 1.51 kB → 1.51 kB
../web3-core/lib/commonjs/web3_context.js 📈 +1 B (+0.01%) 13.44 kB → 13.44 kB
../web3-eth-contract/lib/commonjs/contract.js 📉 -6 B (-0.01%) 45.68 kB → 45.68 kB
../web3-eth-ens/lib/commonjs/ens.js 📉 -2 B (-0.02%) 11.4 kB → 11.4 kB
../web3-eth/lib/commonjs/utils/detect_transaction_type.js 📉 -2 B (-0.04%) 4.96 kB → 4.96 kB
src/web3_eip6963.ts 📉 -2 B (-0.06%) 3.09 kB → 3.08 kB
../web3-rpc-providers/lib/commonjs/types.js 📉 -4 B (-0.22%) 1.76 kB → 1.75 kB
../web3-providers-http/lib/commonjs/index.js 📉 -14 B (-0.31%) 4.41 kB → 4.39 kB
../web3-eth-ens/lib/commonjs/resolver.js 📉 -68 B (-1.03%) 6.42 kB → 6.36 kB
../web3-eth-accounts/lib/commonjs/common/eips/2537.js 📉 -62 B (-1.20%) 5.06 kB → 5 kB
../web3-eth-accounts/lib/commonjs/common/hardforks/shanghai.js 📉 -9 B (-1.94%) 464 B → 455 B
../web3-eth-accounts/lib/commonjs/common/hardforks/london.js 📉 -9 B (-2.27%) 397 B → 388 B
../web3-eth-accounts/lib/commonjs/common/hardforks/mergeForkIdTransition.js 📉 -9 B (-2.59%) 348 B → 339 B
../web3-eth-accounts/lib/commonjs/common/hardforks/berlin.js 📉 -9 B (-2.62%) 344 B → 335 B
../web3-eth-accounts/lib/commonjs/common/hardforks/merge.js 📉 -16 B (-3.23%) 496 B → 480 B
../web3-eth-accounts/lib/commonjs/common/hardforks/spuriousDragon.js 📉 -23 B (-3.31%) 695 B → 672 B
../web3-eth-accounts/lib/commonjs/common/hardforks/grayGlacier.js 📉 -17 B (-3.63%) 468 B → 451 B
../web3-eth-accounts/lib/commonjs/common/eips/3529.js 📉 -32 B (-3.66%) 874 B → 842 B
../web3-eth-accounts/lib/commonjs/common/hardforks/istanbul.js 📉 -109 B (-3.68%) 2.89 kB → 2.79 kB
../web3-eth-accounts/lib/commonjs/common/chains/goerli.js 📉 -103 B (-3.69%) 2.72 kB → 2.62 kB
../web3-eth-accounts/lib/commonjs/common/hardforks/muirGlacier.js 📉 -19 B (-3.72%) 511 B → 492 B
../web3-eth-accounts/lib/commonjs/common/hardforks/arrowGlacier.js 📉 -17 B (-3.76%) 452 B → 435 B
../web3-eth-accounts/lib/commonjs/common/hardforks/constantinople.js 📉 -83 B (-3.78%) 2.15 kB → 2.06 kB
../web3-eth-accounts/lib/commonjs/common/hardforks/homestead.js 📉 -19 B (-3.83%) 496 B → 477 B
../web3-eth-accounts/lib/commonjs/common/hardforks/byzantium.js 📉 -68 B (-3.85%) 1.73 kB → 1.66 kB
../web3-eth-accounts/lib/commonjs/common/chains/sepolia.js 📉 -107 B (-3.86%) 2.71 kB → 2.6 kB
../web3-eth-accounts/lib/commonjs/common/chains/mainnet.js 📉 -118 B (-3.87%) 2.98 kB → 2.86 kB
../web3-eth-accounts/lib/commonjs/common/eips/3860.js 📉 -29 B (-3.92%) 739 B → 710 B
../web3-eth-accounts/lib/commonjs/common/eips/2930.js 📉 -28 B (-3.97%) 705 B → 677 B
../web3-eth-accounts/lib/commonjs/common/eips/2929.js 📉 -106 B (-3.98%) 2.6 kB → 2.5 kB
../web3-eth-accounts/lib/commonjs/common/eips/5133.js 📉 -23 B (-4.00%) 575 B → 552 B
../web3-eth-accounts/lib/commonjs/common/eips/4345.js 📉 -23 B (-4.12%) 558 B → 535 B
../web3-eth-accounts/lib/commonjs/common/eips/3554.js 📉 -23 B (-4.14%) 555 B → 532 B
../web3-eth-accounts/lib/commonjs/common/hardforks/petersburg.js 📉 -49 B (-4.15%) 1.15 kB → 1.11 kB
../web3-eth-accounts/lib/commonjs/common/hardforks/tangerineWhistle.js 📉 -54 B (-4.22%) 1.25 kB → 1.2 kB
../web3-eth-accounts/lib/commonjs/common/eips/1559.js 📉 -35 B (-4.29%) 816 B → 781 B
../web3-eth-accounts/lib/commonjs/common/eips/2565.js 📉 -23 B (-4.30%) 535 B → 512 B
../web3-eth-accounts/lib/commonjs/common/eips/2718.js 📉 -17 B (-4.42%) 385 B → 368 B
../web3-eth-accounts/lib/commonjs/common/eips/3541.js 📉 -19 B (-4.45%) 427 B → 408 B
../web3-eth-accounts/lib/commonjs/common/hardforks/chainstart.js 📉 -541 B (-4.46%) 11.86 kB → 11.33 kB
../web3-eth-accounts/lib/commonjs/common/hardforks/dao.js 📉 -15 B (-4.49%) 334 B → 319 B
../web3-eth-accounts/lib/commonjs/common/eips/2315.js 📉 -33 B (-4.56%) 724 B → 691 B
../web3-eth-accounts/lib/commonjs/common/eips/3607.js 📉 -21 B (-4.63%) 454 B → 433 B
../web3-eth-accounts/lib/commonjs/common/eips/3198.js 📉 -23 B (-4.65%) 495 B → 472 B
../web3-eth-accounts/lib/commonjs/common/eips/4399.js 📉 -21 B (-4.75%) 442 B → 421 B
../web3-eth-accounts/lib/commonjs/common/eips/3855.js 📉 -25 B (-4.78%) 523 B → 498 B
../web3-eth-accounts/lib/commonjs/common/eips/1153.js 📉 -30 B (-4.78%) 627 B → 597 B
../web3-eth-accounts/lib/commonjs/common/eips/3675.js 📉 -21 B (-4.84%) 434 B → 413 B
../web3-eth-accounts/lib/commonjs/common/eips/3540.js 📉 -21 B (-4.88%) 430 B → 409 B
../web3-eth-accounts/lib/commonjs/common/eips/3670.js 📉 -21 B (-4.94%) 425 B → 404 B
../web3-eth-accounts/lib/commonjs/common/eips/3651.js 📉 -21 B (-5.04%) 417 B → 396 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 617.15 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

github-actions[bot] avatar Aug 05 '24 07:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 88.80000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (5080e80) to head (ecd1ffc). Report is 20 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7187      +/-   ##
==========================================
- Coverage   94.46%   94.42%   -0.05%     
==========================================
  Files         215      215              
  Lines        8403     8410       +7     
  Branches     2318     2329      +11     
==========================================
+ Hits         7938     7941       +3     
- Misses        465      469       +4     
Flag Coverage Δ
UnitTests 94.42% <88.80%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 05 '24 07:08 codecov[bot]

Done at another MR

Muhammad-Altabba avatar Sep 23 '24 13:09 Muhammad-Altabba