web3.js
web3.js copied to clipboard
fix(type): Add the missing types to the ”accounts“
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
- [ ] I have selected the correct base branch.
- [ ] I have performed a self-review of my own code.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have made corresponding changes to the documentation.
- [ ] My changes generate no new warnings.
- [ ] Any dependent changes have been merged and published in downstream modules.
- [ ] I ran
npm run lint
with success and extended the tests and types if necessary. - [ ] I ran
npm run test:unit
with success. - [ ] I ran
npm run test:coverage
and my test cases cover all the lines and branches of the added code. - [ ] I ran
npm run build
and testeddist/web3.min.js
in a browser. - [ ] I have tested my code on the live network.
- [ ] I have checked the Deploy Preview and it looks correct.
- [ ] I have updated the
CHANGELOG.md
file in the root folder. - [ ] I have linked Issue(s) with this PR in "Linked Issues" menu.
According to the documentation at https://docs.web3js.org/libdocs/Accounts, add the missing types to the account
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.03%. Comparing base (
4358140
) to head (3f0c15f
). Report is 229 commits behind head on 4.x.
:exclamation: Current head 3f0c15f differs from pull request most recent head c7f8344. Consider uploading reports for the commit c7f8344 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## 4.x #6762 +/- ##
==========================================
+ Coverage 87.37% 92.03% +4.65%
==========================================
Files 197 214 +17
Lines 7548 8171 +623
Branches 2059 2200 +141
==========================================
+ Hits 6595 7520 +925
+ Misses 953 651 -302
Flag | Coverage Δ | |
---|---|---|
UnitTests | 92.03% <ø> (+4.65%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
web3 | ∅ <ø> (∅) |
|
web3-core | ∅ <ø> (∅) |
|
web3-errors | ∅ <ø> (∅) |
|
web3-eth | ∅ <ø> (∅) |
|
web3-eth-abi | ∅ <ø> (∅) |
|
web3-eth-accounts | ∅ <ø> (∅) |
|
web3-eth-contract | ∅ <ø> (∅) |
|
web3-eth-ens | ∅ <ø> (∅) |
|
web3-eth-iban | ∅ <ø> (∅) |
|
web3-eth-personal | ∅ <ø> (∅) |
|
web3-net | ∅ <ø> (∅) |
|
web3-providers-http | ∅ <ø> (∅) |
|
web3-providers-ipc | ∅ <ø> (∅) |
|
web3-providers-ws | ∅ <ø> (∅) |
|
web3-rpc-methods | ∅ <ø> (∅) |
|
web3-utils | ∅ <ø> (∅) |
|
web3-validator | ∅ <ø> (∅) |
LGTM. Thanks for your contribution. Please fix lint test
@electroluxcode could you fix conflicting file and above comments, Thanks
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.
closing this PR as it will be merged via https://github.com/web3/web3.js/pull/7011 Thanks @electroluxcode