web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Decode ABI method added

Open jerkly opened this issue 1 year ago • 2 comments

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6220

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x] I have selected the correct base branch.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run lint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:unit with success.
  • [ ] I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • [x] I ran npm run build and tested dist/web3.min.js in a browser.
  • [x] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.
  • [x] I have linked Issue(s) with this PR in "Linked Issues" menu.

jerkly avatar Jan 04 '24 20:01 jerkly

Codecov Report

Merging #6690 (b7ff4b4) into 4.x (4358140) will increase coverage by 4.57%. Report is 212 commits behind head on 4.x. The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6690      +/-   ##
==========================================
+ Coverage   87.37%   91.95%   +4.57%     
==========================================
  Files         197      215      +18     
  Lines        7548     8201     +653     
  Branches     2059     2214     +155     
==========================================
+ Hits         6595     7541     +946     
+ Misses        953      660     -293     
Flag Coverage Δ
UnitTests 91.95% <0.00%> (+4.57%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

codecov[bot] avatar Jan 05 '24 07:01 codecov[bot]

Hi @jerkly, Do you like to finalize this PR? Many thanks,

Muhammad-Altabba avatar Jan 29 '24 10:01 Muhammad-Altabba

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

github-actions[bot] avatar Mar 30 '24 00:03 github-actions[bot]

The work for this change will be done at https://github.com/web3/web3.js/pull/6950

Muhammad-Altabba avatar Apr 04 '24 16:04 Muhammad-Altabba