web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

chore: yarn workspaces

Open mpetrunic opened this issue 2 years ago • 3 comments

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Only pending thing is to update release process. I think you current flow matches https://yarnpkg.com/features/release-workflow

Where you would commit version bumps into yarn directory on every PR and when releasing, you would apply it and let yarn guides you interactively trough package bumps stored before.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build with success.
  • [ ] I have tested the built dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • [ ] I have selected the correct 4.x base branch.
  • [ ] Within the description, the feature or issue is discussed in detail or an issue is linked.
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have added any required tests for the changes I made
  • [ ] I have made corresponding changes to the documentation
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran yarn successfully
  • [ ] I ran yarn lint successfully
  • [ ] I ran yarn build:web successfully
  • [ ] I ran yarn test:unit successfully
  • [ ] I ran yarn test:integration successfully
  • [ ] I ran compile:contracts successfully
  • [ ] I have tested my code.
  • [ ] I have updated the corresponding CHANGELOG.md file in the packages I have edited.

mpetrunic avatar Dec 09 '22 14:12 mpetrunic

Your Render PR Server URL is https://atweb3js-docs-pr-5701.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ce9k0varrk0dj0nqeq30.

render[bot] avatar Dec 09 '22 14:12 render[bot]

related to https://github.com/web3/web3.js/issues/5006

mpetrunic avatar Dec 09 '22 14:12 mpetrunic

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

github-actions[bot] avatar Mar 19 '23 00:03 github-actions[bot]