web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

console.warn considered harmfull

Open superboss224 opened this issue 2 years ago • 0 comments

https://github.com/web3/web3.js/blob/c924148e34600e61c4d1326a9d30fcec83fa9f97/packages/web3-eth-ens/src/lib/ResolverMethodHandler.js#L245

The harmfull console.warn here should be removed, the lib should not display an error message if we are already catching potential errors in our code

More information : https://www.slideshare.net/dd105/logging-consideredharmful

superboss224 avatar Sep 15 '22 19:09 superboss224