web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Nikos/5240/ens resolver 4.x system tests

Open nikoulai opened this issue 2 years ago • 3 comments

Description

Integration tests for resolver functions in ens package #5240

Checklist for 4.x:

  • [ ] I have selected the correct 4.x base branch.
  • [ ] Within the description, the feature or issue is discussed in detail or an issue is linked.
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have added any required tests for the changes I made
  • [ ] I have made corresponding changes to the documentation
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran yarn successfully
  • [ ] I ran yarn lint successfully
  • [ ] I ran yarn build:web successfully
  • [ ] I ran yarn test:unit successfully
  • [ ] I ran yarn test:integration successfully
  • [ ] I ran compile:contracts successfully
  • [ ] I have tested my code.
  • [ ] I have updated the corresponding CHANGELOG.md file in the packages I have edited.

nikoulai avatar Sep 14 '22 09:09 nikoulai

Your Render PR Server URL is https://web3js-docs-pr-5437.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ccgqavkgqg44sarkb2dg.

render[bot] avatar Sep 14 '22 09:09 render[bot]

@nikoulai could you also check tests that are not passing in CI , Thanks

jdevcs avatar Sep 16 '22 14:09 jdevcs

before merging, could you check failing tests in CI. I saw logs in eth package, are there any changes in this PR caused? I think not.

@jdevcs No there are no changes affecting web3-eth. Same tests fail in other PRs too. (https://github.com/web3/web3.js/issues/5456)

nikoulai avatar Sep 19 '22 15:09 nikoulai