web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

updating pull request template

Open luu-alex opened this issue 2 years ago • 2 comments

#5186

Description

Updating the PR template to include a 4.x checklist, PR templates must be updated on the default branch (1.x).

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build with success.
  • [ ] I have tested the built dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.

luu-alex avatar Aug 03 '22 18:08 luu-alex

Your Render PR Server URL is https://web3-js-pr-5310.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cblbroarrk02sbm4ig7g.

render[bot] avatar Aug 03 '22 18:08 render[bot]

Also open PR for merging it in 4.x branch, for future use. @luu-alex

jdevcs avatar Aug 09 '22 15:08 jdevcs