web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Stop waiting after `transactionBlockTimeout`

Open Muhammad-Altabba opened this issue 2 years ago • 3 comments

Implements https://github.com/chainsafe/web3.js/issues/5113

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build with success.
  • [ ] I have tested the built dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.

Muhammad-Altabba avatar Jul 28 '22 18:07 Muhammad-Altabba

Your Render PR Server URL is https://web3js-docs-pr-5294.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cbhd26uhb05sparsh130.

render[bot] avatar Jul 28 '22 18:07 render[bot]

This pull request introduces 1 alert when merging fe4cddd06d9ecdba7fac8130be655dd5ad8f6993 into aeceed263c4b031e57ae32b5acd452b08a75a505 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 29 '22 14:08 lgtm-com[bot]

LGTM, just a small comment. overall great work

luu-alex avatar Sep 09 '22 10:09 luu-alex