web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Add blackbox to workflow

Open nikoulai opened this issue 3 years ago • 24 comments

Description

Fixes #5261

Checklist:

  • [ ] I have selected the correct base branch.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build with success.
  • [ ] I have tested the built dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.

nikoulai avatar Jul 25 '22 22:07 nikoulai

This pull request introduces 1 alert when merging c8db0f1e2b96eae052c737df4af5eab88ba79f9d into 6147cfb623f253f206dafdf07ba9a3652208dd50 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 12:07 lgtm-com[bot]

This pull request introduces 1 alert when merging 01a85063c31ca9a93ffd9490736466735d6b8f92 into 6147cfb623f253f206dafdf07ba9a3652208dd50 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 12:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging b44cfc71411793def12d709dabe49a20d0d99b8f into 6147cfb623f253f206dafdf07ba9a3652208dd50 - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 14:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 48771c6cbbc51ae66ec82d82b98762e23dfed6ff into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 15:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 2f667c76471bbb12feebd41df8e2562643f4ea58 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 15:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 80393cee7498be94e13bec354ac2064b01a4f4b4 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 15:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging e0496fc5e9f7bae253359987b81bd5920035406a into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 15:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 5c502c648b0f9c014086495c71d45e78a51c4963 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 15:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 0684da6417372e5cc335bef827c59cea8b5fd15d into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 16:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 467aeb8a8cad1fe3855e7f28b91df5074412ee64 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 16:07 lgtm-com[bot]

This pull request introduces 3 alerts when merging 8ba1ac6e3ca62a791dfc7e5f01733b295db2129d into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 18:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 3ccf9ee371f87627571bef506efb16735abc7b4c into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 18:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 0629516e6a0c75f59b958cc299c44588f2afe66d into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 18:07 lgtm-com[bot]

This pull request introduces 3 alerts when merging a0bbcc142f6589fae66950c884fce775caff63ae into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 21:07 lgtm-com[bot]

This pull request introduces 3 alerts when merging 79535b961a0d04b11f103b412dd75d6a79b613cc into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 22:07 lgtm-com[bot]

This pull request introduces 3 alerts when merging a0f20f3705332b146f0e10f80da97286313ce67c into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 27 '22 22:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 29df7fc9c7b356a4bb105ecb7bba29a1e249cb1b into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 28 '22 10:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 47d3354d7fb6524644c837773cb57cb45ec827b4 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 28 '22 11:07 lgtm-com[bot]

This pull request introduces 3 alerts when merging c8cc1fc34e44452e7c4fd8e6783ea6d924310eb2 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types
  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 28 '22 11:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging c7fb736771d3a28715dfdb55a790a1e1e40b1697 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 28 '22 11:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging 4e848ef8aff0d02aca399e3c230b4901fcc295ca into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 28 '22 13:07 lgtm-com[bot]

This pull request introduces 2 alerts when merging cdeb2e750455c3a00604db05ada4d107fe01977c into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 28 '22 13:07 lgtm-com[bot]

Your Render PR Server URL is https://web3js-docs-pr-5280.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cbh9q7vs437itcsg0hg0.

render[bot] avatar Jul 28 '22 14:07 render[bot]

This pull request introduces 2 alerts when merging f99a7329a542c22434a38fcc107751d35242a820 into 0b903378be4cee0f2a9dc2c0572ffcbce5e97afd - view on LGTM.com

new alerts:

  • 1 for Useless conditional
  • 1 for Comparison between inconvertible types

lgtm-com[bot] avatar Jul 28 '22 14:07 lgtm-com[bot]

@spacesailor24 i wasnt sure if web was complete or not, but its related to the html file that was created. blackbox_test/index.html

luu-alex avatar Aug 11 '22 17:08 luu-alex

@spacesailor24 @nikoulai

jdevcs avatar Aug 16 '22 11:08 jdevcs

Hi @nikoulai can we close this PR for https://github.com/ChainSafe/web3.js/pull/5353

jdevcs avatar Aug 23 '22 12:08 jdevcs