web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Add `removed` property to `Log` type

Open samlaf opened this issue 3 years ago • 2 comments

Attempt at Fixing https://github.com/ChainSafe/web3.js/issues/4747#issue-1119059382

This is just trying to move forward in fixing this issue. I don't have the time to deep dive into web3js and try to understand how to make sure that this PR is non-breaking, so would like for someone else to help me verify.

I just added the property and ran tsc --noEmit in packages/web3-core which type checked. However I am not sure if it breaks some of the other web3 packages, since when running tsc --noEmit in the root folder, I get a gazillion type errors from the tests, such as

packages/web3-utils/types/tests/string-to-hex-test.ts:40:13 - error TS2345: Argument of type 'boolean' is not assignable to parameter of type 'string'.

40 stringToHex(true);

which comes from

// $ExpectError
stringToHex(true);

Perhaps we could add // @ts-ignore above these lines, but I'm not sure if it wouldn't break the // $ExpectError commands (maybe only the line before the actual test applies?).

samlaf avatar Mar 21 '22 20:03 samlaf

Pull Request Test Coverage Report for Build 2161428870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.217%

Totals Coverage Status
Change from base Build 2155746686: 0.0%
Covered Lines: 3372
Relevant Lines: 4401

💛 - Coveralls

coveralls avatar Apr 13 '22 13:04 coveralls

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

github-actions[bot] avatar Jul 04 '22 00:07 github-actions[bot]

Merged into 1.x via https://github.com/web3/web3.js/pull/5576

jdevcs avatar Oct 28 '22 11:10 jdevcs