web3.storage
web3.storage copied to clipboard
Resolve error with users not on pinning service but loading the accounts page
Need to resolve error on accounts page with users that have no pinning service access. If user has pinning service not allowed, then error occurs. (see error thrown in screenshot below)
- [ ] investigate whether or not pinning service allowlist impacts loading of the utilization bar (as seen in screenshot below)
- [ ] if error has impact on user experience on front end functionality, fix appropriately
- [ ] handle the uncaught exception from api as described by Bengo in comments.
Bengo reported a series of errors in Sentry, which may (or may not) be related to this specific issue described above. (see below for details).
Bengo Report
FYI there is also this error happening ~1000 times per day. It looks like it only gets called from api userAccountGet, which might be called as often as every login or something via this website UserProvider (idk, never used it). Seems like it could affect users.
Error in Console
I don't think the sentry errors are related to the pinning API
Need to resolve error on accounts page with users that have no pinning service access.
Why do we need to?
If the motivation for this was the error in the console, I think instead of fixing the underlying error, we should prioritize the http api not returning uncaught error messages at all in production, which is a security vulnerability.
That's why e.g. expressjs blocks it
If you pass an error to next() and you do not handle it in a custom error handler, it will be handled by the built-in error handler; the error will be written to the client with the stack trace. The stack trace is not included in the production environment.
And it's probably also a good idea (but afaict not urgent) to look into the underlying error, but IMO it's not worth prioritizing above the aforementioned concern. The underlying error has been around for 6+ weeks and I haven't seen it affecting anything functional, but do tell if you know more.
Need to because in initial test (per screenshots) the utilization bar never loads. This could mean users with no pinning service access will experience the eternal "loading" on that bar. I did clarify steps needed in the description above (more investigation and diagnosis, and fixing if it is indeed an issue).
Regarding the console error message, sounds like we need to first determine if this presents a bug for user (as described above) then also handle the exception error as a separate step/task (unless I'm misunderstanding something). I clarified next steps in description above. Feel free to adjust if needed.
I think there are two orthogonal issues:
- the js console error mentioning pinning api - this is what I was pushing back on whether it's urgently needed (if unrelated to the next thing)
- bug where the bar doesn't load - This bugs me too, see slack here for product input