web3.storage icon indicating copy to clipboard operation
web3.storage copied to clipboard

FE - Upload & Pins file manager table refactor

Open joshJarr opened this issue 2 years ago • 2 comments

There's been a few issues related to the uploads and pins tables.

  • Pagination code is tough to work with since there are many components changing data, and Upload and Pin logic is tightly coupled.
  • There's some inefficiencies in calls, sometimes the table is loaded before requesting pins, resulting in content jumping shortly after loading
  • when "View results" is change when on page 2 or more and causes the request to be out of range the table breaks. Refreshing does not fix this as the url params persist the broken state.
  • Pins cannot be sorted
  • We have lost pagination counts (only get prev, next, first, last), a user cannot jump to a page beyond these.

joshJarr avatar Sep 02 '22 15:09 joshJarr

Linked PR: https://github.com/web3-storage/web3.storage/pull/1699

joshJarr avatar Sep 02 '22 15:09 joshJarr

This PR now has a few conflicts for us to fix since a hotfix was merged https://github.com/web3-storage/web3.storage/pull/1739 We should ensure the hotfixed issues have not regressed due to our conflict management.

joshJarr avatar Sep 05 '22 13:09 joshJarr

Closing this as it's covered by other smaller tickets.

mbommerez avatar Oct 12 '22 10:10 mbommerez