web3.storage icon indicating copy to clipboard operation
web3.storage copied to clipboard

CI workflows hitting rate-limit errors

Open olizilla opened this issue 3 years ago • 1 comments

looks like our CI builds on web3.storage are occasionally hitting github api rate-limits which is causing intermittent and suprising builds failures.

  • in the PR that created the w3 cli release PR, we hit a rate-limit and it made the CHANGELOG for that module come out wrong… (which is bad, as a failure would be preferable to an stealthy erroneous success) https://github.com/web3-storage/web3.storage/pull/1695
  • in #1754 there was a surprising rate-limit error when looking up the PR to set the website preview comment on. https://github.com/web3-storage/web3.storage/pull/1754#pullrequestreview-1074855296

Could we really be making > 1000 api reqs per hour? Do we have a workflow that is overly chatty? It seems like a lot, even for a busy team.

When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. – https://docs.github.com/en/rest/overview/resources-in-the-rest-api#requests-from-github-actions

If it is GitHub rate limiting us, then we could pay GitHub to make this not a problem for an order of magnitude.

For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

olizilla avatar Aug 22 '22 13:08 olizilla

We should definitely try having just one workflow invoke release-please, instead of one-per-package https://github.com/google-github-actions/release-please-action/issues/286#issuecomment-926778856

gobengo avatar Aug 23 '22 16:08 gobengo