web-vision
[TASK] Streamline Localization handling
Hardblock :stop_sign: -2
Points
1. localization modal / text running out of field
The "fixing" for the "label" is not "needed" in that way. That was already fixed, but limited to 13.4.3 which was an error. The core fix took longer until it got merged (13.4.10 released this week).
Here the "custom" class in the JS modal needs to be kept, and the CSS loading limit changed from <13.4.2 to <13.4.10 in ext_localconf.php.
- Commit: 1eafd9de108b28cc6b882c4c8bdcfe12ac517cd8
- TYPO3 Forge: https://forge.typo3.org/issues/105853
- TYPO3 Patch (main): https://review.typo3.org/c/Packages/TYPO3.CMS/+/87576
- TYPO3 Patch (13.4.10): https://review.typo3.org/c/Packages/TYPO3.CMS/+/89127
2. change of behaviour (only v13 in current patch state
Due to the refactoring the "error/hint" when API key has not been configured are no longer shown in the selection and the deepltranslate items "disabled" (not selectable).
That means, that with missing API key the options are "simply" not available, no notice for that. Do we really want this ? (Technically it's good to remove that).
3. removed configuration lookup code / dropped ajax route and controller
I love that removal in general, even more as this removes sequentially retriggered ajax calls. However, only v13 JavaScript has been recompiled leaving the v12 JavaScript still trying to call that ajax endpoint removed with this pull request.
That means, we need to adjust the TYPO3 v12 JavaScript in the same way.
4. PageTS options
This is nice, but that is really a feature and should be handled as such and honored with a dedicated pull-request, so it is emphasized in the GitHub generated release notes and not hidden away with a PR not really mentioning it.
Summary
There are quite some things we need to address and change, and I'd suppose to split it into dedicated parts. Must have is not breaking v12 support.
