jwt-framework icon indicating copy to clipboard operation
jwt-framework copied to clipboard
verified publisher icon web-token

Try symplify instead of gitsplit

Open szepeviktor opened this issue 3 years ago • 1 comments

Description

It is a better tool.

https://github.com/symplify/monorepo-builder 👀

That is all.

Example

No response

szepeviktor avatar Aug 23 '22 21:08 szepeviktor

Hi @szepeviktor,

This looks good to me. I will give it a try and see how to use it here. Many thanks.

Spomky avatar Aug 24 '22 05:08 Spomky

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 24 '22 07:09 stale[bot]

Dear @stalebot, please let Florent think!

szepeviktor avatar Sep 24 '22 08:09 szepeviktor

Even though this tool is very interesting, gitsplit lite is sufficient for this project. The only feature I miss is signing sub repositories, but I haven't seen that feature on this tool I prefer to leave the configuration as it is for the moment. Thanks

Spomky avatar May 18 '23 15:05 Spomky

sufficient

Me (a perfectionist) is not able to comprehend that word 🙃 Sorry.

szepeviktor avatar May 18 '23 15:05 szepeviktor

hummm. OK I integrated it here. The CI/CD is broken, but it is related to another workflow.

Spomky avatar May 18 '23 16:05 Spomky

😲

What??

szepeviktor avatar May 18 '23 16:05 szepeviktor

This config file looks beautiful!! ❤️ https://github.com/web-token/jwt-framework/blob/3.2.x/monorepo-builder.php

(meaning readable and sustainable)

szepeviktor avatar May 18 '23 16:05 szepeviktor

I cannot figure out what is going on with the configuration I use here. The github action is called as expected, but tags are not propagated. It looks like I missed something, but what? When a milestone is closed (e.g. 3.2.5), the tag is correctly added on the monorepo. This is done by this action (+ other cool stuff like branch/milestone creation and merge-up PRs). But when the split action is closed, tags are missing. Any thoughts on this?

Spomky avatar May 19 '23 13:05 Spomky

@tomasvotruba Could you help? I've never seen a monorepo from the inside.

szepeviktor avatar May 22 '23 09:05 szepeviktor

Hey, I don't use it much latelly.

But here is a Github action to kick off: https://github.com/danharrin/monorepo-split-github-action

TomasVotruba avatar May 22 '23 09:05 TomasVotruba

Closing for now. The whole split system will be revised in the next minor release.

Spomky avatar Jan 04 '24 16:01 Spomky

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Feb 25 '24 04:02 github-actions[bot]