jwt-framework icon indicating copy to clipboard operation
jwt-framework copied to clipboard

JWEBuilder, JWSBuilder, multiple AlgorithmManagers

Open devsi opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. I have to clone the AlgorithmManager, or create a new instance with just the one algorithm when new-ing up JWEBuilder and JWSBuilder. Their signature is JWSBuilder($algorithmManager, $algorithmManager, $compressionManager).

Describe the solution you'd like If it is truly a manager, it should only be needed once, instead of having to replicate the class. If the one manager contains both the CEK and the KeyEncryption algorithms then they can be referenced by name when used.

Screen Shot 2019-11-27 at 10 50 41 AM

devsi avatar Nov 27 '19 18:11 devsi

Again, apologies for creating issues! I'm just listing frustrations as I hit them while developing with the library.

devsi avatar Nov 27 '19 18:11 devsi

Hi @devsi,

Sorry for the late answer. Just to be clear with that: don't apology for creating issues! I really appreciate that. I really need such feedback to improve the framework, especially if it is related to UX/DX.

I concur with you. The use of 2 algorithm managers adds an unnecessary complexity and the constructor should be changed.

Spomky avatar Dec 02 '19 08:12 Spomky

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 22 '20 06:06 stale[bot]

Done in 3.3.x

Spomky avatar Feb 22 '24 07:02 Spomky

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Apr 10 '24 04:04 github-actions[bot]