react-native-paper-dates icon indicating copy to clipboard operation
react-native-paper-dates copied to clipboard

testing the disabling

Open airam666 opened this issue 5 years ago • 10 comments

DIsabling a field in datapickermodal

airam666 avatar Mar 26 '21 21:03 airam666

This is useful! I'd like to have this feature!

lmichailian avatar Mar 31 '21 16:03 lmichailian

Thanks for your PR but I think it should always be editable if it's inside the validRange

RichardLindhout avatar Apr 06 '21 20:04 RichardLindhout

@imi

This is useful! I'd like to have this feature!

Can you describe why you want to disable it?

RichardLindhout avatar Apr 07 '21 18:04 RichardLindhout

There are a few bugs that I have noticed with editing. I would also like the option of disabling input. Please see the attached vide:

https://user-images.githubusercontent.com/54547556/114092957-bd561e80-9877-11eb-9146-6edb31390768.mov

davehenriksen2711 avatar Apr 08 '21 20:04 davehenriksen2711

@davehenriksen2711 we need to fix issues like this indeed! Note that on real devices the software keyboard will show only numbers. But I'd rather want the users to be able to change the date and fix the issues which is why the input would need to be disabled.

RichardLindhout avatar Apr 08 '21 20:04 RichardLindhout

@imi

This is useful! I'd like to have this feature!

Can you describe why you want to disable it?

The app I'm working with have a new specification that requires the field is not visible. I don't want to use another library since I like a lot this one

airam666 avatar Apr 08 '21 20:04 airam666

@airam666 maybe describe to them you're following the Material Design guidelines and it's not technically easy to remove it https://material.io/components/date-pickers#usage.

I think they'll understand it since I think it's a good feature a user will still be able to have keyboard input. I understand your use-case but I rather follow only the guidelines since if we go another route I have more work on other features too. I hated the react-native-paper standpoint to only follow the guidelines very much but now I think it's a good idea.

RichardLindhout avatar Apr 08 '21 20:04 RichardLindhout

Thanks Richard, that's a good point about real devices only having numbers for input. The issue in the video is also happening for the web though.

davehenriksen2711 avatar Apr 08 '21 20:04 davehenriksen2711

Yeah will fix when I work on the library the next time!

RichardLindhout avatar Apr 08 '21 21:04 RichardLindhout

I decided I want this! But the library has changed a bit is somebody able to resolve conflicts?

RichardLindhout avatar Oct 20 '21 23:10 RichardLindhout

Closed in favor of https://github.com/web-ridge/react-native-paper-dates/pull/256

iM-GeeKy avatar Feb 18 '23 14:02 iM-GeeKy