web-platform-tests
Add a few tests for whether CSS subresources are critical
tests for https://github.com/w3c/csswg-drafts/issues/1088
these should be moved somewhere better once we know what directory to put them in
Firefox (nightly channel)
Testing web-platform-tests at revision 5048fcbb7d4f38e5699c85af809fe35483db5cbb Using browser at version BuildID 20170409194145; SourceStamp 45692c884fdd5136a64fb2f8a61a0c8183b69331 Starting 10 test iterations All results were stable
All results
5 tests ran
/unspecified-css-subresources/background-image.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for background-image |
PASS |
/unspecified-css-subresources/font-face-unused.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load doesn't wait for unused @font-face |
PASS |
/unspecified-css-subresources/font-face-used.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for used @font-face |
PASS |
/unspecified-css-subresources/import.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for @import |
PASS |
/unspecified-css-subresources/list-style-image.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for list-style |
PASS |
Chrome (unstable channel)
Testing web-platform-tests at revision 5048fcbb7d4f38e5699c85af809fe35483db5cbb Using browser at version 59.0.3063.4 dev Starting 10 test iterations All results were stable
All results
5 tests ran
/unspecified-css-subresources/background-image.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for background-image |
PASS |
/unspecified-css-subresources/font-face-unused.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load doesn't wait for unused @font-face |
PASS |
/unspecified-css-subresources/font-face-used.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for used @font-face |
PASS |
/unspecified-css-subresources/import.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for @import |
PASS |
/unspecified-css-subresources/list-style-image.html
| Subtest | Results | Messages |
|---|---|---|
| OK | ||
load waits for list-style |
PASS |
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!
While the CSS WG has still not resolved the above issue, these tests do at this point show identical behaviour across all three major browser engines, hence on the whole I'd be in favour of landing these as tentative tests if someone wants to review them.
For some reason this thread was buried in my inbox and it doesn't look there's been much activity in a while. Are you still seeking review @gsnedders? Has there been any more consensus or spec updates here?
Has there been any more consensus or spec updates here?
Not that I'm aware of; that said, I'm still in favour of review (and landing) the tests which pass in all three major browser engines, as we may as well have tentative tests that assert the current intersection behaviour (and ensure we don't move away from interoperability there).
Another variation for these tests that could be useful to include in this PR is: moving all of the <style> block contents to a <link rel=stylesheet> and seeing if the link element's load event is indeed blocked when the Document's load event is blocked.
In https://github.com/w3c/csswg-drafts/issues/1088#issuecomment-427126353, Hiroshige points out that apparently Chrome blocks the Document's load event in some cases where the <link> element's load event is not blocked, which is pretty interesting. It would be good to know what browsers do here more generally.
Another variation for these tests that could be useful to include in this PR is: moving all of the
<style>block contents to a<link rel=stylesheet> and seeing if the link element's load event is indeed blocked when the Document's load event is blocked.
I'll fix the nits you mentioned above, but I probably won't expand the coverage of this (I don't really immediately have the time to actually work on this right now).