wpt icon indicating copy to clipboard operation
wpt copied to clipboard

Digital Credentials: test create and get

Open marcoscaceres opened this issue 1 year ago • 1 comments

Closes https://github.com/WICG/digital-credentials/issues/118

Creates a spec compliant set of test case and adds a more robust/flexible cross-origin testing framework:

  • helper.js
  • iframe.html

Removes/refactors the old "digital-credentials/digital-credentials.tentative.https.html", as these were not spec compliant.

Adds TypeScript types, for better workflow in VS Code, etc.

marcoscaceres avatar Jun 06 '24 05:06 marcoscaceres

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

wpt-pr-bot avatar Jun 06 '24 05:06 wpt-pr-bot

Let me know when you are ready for another round of code review :)

pkotwicz avatar Jul 17 '24 17:07 pkotwicz

@pkotwicz, I think these should be good to go now. Appreciate another review.

marcoscaceres avatar Jul 17 '24 22:07 marcoscaceres

Wanted to apologize for the long delay in the code review. My github e-mail settings were screwed up

pkotwicz avatar Aug 02 '24 14:08 pkotwicz

Let me know when you want another review on this CL

pkotwicz avatar Aug 07 '24 14:08 pkotwicz

@pkotwicz, sorry for the slow churn on this... implementing in WebKit in parallel, so just coming back to this now.

Can you please take another look, also at https://github.com/web-platform-tests/wpt/pull/47662 ?

marcoscaceres avatar Aug 19 '24 03:08 marcoscaceres