wpt
wpt copied to clipboard
[WebDriver BiDi] fix `test_release_mouse_sequence_resets_dblclick_state`
- Move test to tentative, as the expected behavior is not clear yet.
- Remove parameter, as the double click is tested in
test_dblclick_at_coordinates.
@sadym-chromium could you maybe explain what is/was broken with the test?
@sadym-chromium could you maybe explain what is/was broken with the test?
sure!
- The test
test_release_mouse_sequence_resets_dblclick_statechecks both with and without release, which is confusing. - Moving it to tentative until the https://github.com/w3c/webdriver/issues/1772 is clarified.
@sadym-chromium could you maybe explain what is/was broken with the test?
- If there is no
releaseactions, why thedblclickshould be absent at all?
2. Moving it to tentative until the [Clarify how the double click tracking should work in the actions w3c/webdriver#1772](https://github.com/w3c/webdriver/issues/1772) is clarified.
Would you mind renaming the test so that it includes tentative in its name?
Would you mind renaming the test so that it includes
tentativein its name?
@whimboo done
You moved the test below a tentative folder which is not what we usually do for tentative wpt tests. As mentioned in my review please add the word to the test name: webdriver/tests/bidi/input/release_actions/sequence_tentative.py
Otherwise I assume (didn't check the changes directly) it is just moving the existing tests without any further changes?
You moved the test below a
tentativefolder which is not what we usually do for tentative wpt tests. As mentioned in my review please add the word to the test name:webdriver/tests/bidi/input/release_actions/sequence_tentative.py
Got it. Done.
Otherwise I assume (didn't check the changes directly) it is just moving the existing tests without any further changes?
Yes, except release_actions parameter:
@pytest.mark.parametrize(
"release_actions",
[True, False],
ids=["with release actions", "without release actions"],
)
...
if release_actions:
await bidi_session.input.release_actions(context=top_context["context"])
@whimboo any other concerns?