wpt icon indicating copy to clipboard operation
wpt copied to clipboard

Test priority of cICP over iCCP

Open svgeesus opened this issue 1 year ago • 3 comments

PNG Third edition says:

When the cICP chunk is present, decoders that recognize it SHALL ignore the following chunks:

iCCP

The test file is a PNG with solid sRGB green (0, 128, 0) converted to Display P3 (0.21603749037034126, 0.49418159073224005, 0.13151307826427636). The image has a Display P3 cICP chunk. It also has an iCCP chunk containing a modified sRGB ICC profile; the red and green colorants are swapped so, if used, the result will be a deep red.

The test HTML also starts with a solid red, in case the image is not loaded at all.

The reference uses an sRGB PNG which is sRGB green (0, 128, 0).

svgeesus avatar Feb 19 '24 07:02 svgeesus

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

wpt-pr-bot avatar Feb 19 '24 07:02 wpt-pr-bot

@ProgramMax

svgeesus avatar Feb 19 '24 07:02 svgeesus

LGTM, except for the lint error.

It says you need a link to the spec. You have two, though. I'm not sure why it doesn't recognize them.

ProgramMax avatar Feb 19 '24 07:02 ProgramMax

Yeah I don't understand the lint error either, especially as it mentions an entirely unrelated spec:

css/css-highlight-api/historical.window.js: Testcase file must have a link to a spec (MISSING-LINK)

svgeesus avatar Feb 20 '24 15:02 svgeesus

@web-platform-tests/wpt-core-team any help on resolving this apparently unrelated lint error?

svgeesus avatar Feb 20 '24 15:02 svgeesus

Rebase to the latest master (or any commit after https://github.com/web-platform-tests/wpt/commit/b31783e518cd5c95f3143027fd31ab5b11f3bb36 )

zcorpan avatar Feb 20 '24 15:02 zcorpan

@ProgramMax you have been added to the reviewer pool, please approve

svgeesus avatar Feb 20 '24 18:02 svgeesus