wpt icon indicating copy to clipboard operation
wpt copied to clipboard

Fetch: Add tests for AbortSignal's abort reason

Open nidhijaju opened this issue 3 years ago • 2 comments

This PR adds test cases to check the functionality of AbortSignal's abort reason when aborting fetch.

See https://github.com/whatwg/fetch/pull/1343 for accompanying spec changes.

nidhijaju avatar Aug 08 '22 08:08 nidhijaju

The added cases look good. I think we should test that the service worker can observe the fetch abort and see the contents of the abort reason.

yutakahirano avatar Aug 08 '22 08:08 yutakahirano

The added cases look good. I think we should test that the service worker can observe the fetch abort and see the contents of the abort reason.

I added a new test for this case, so hopefully it's looking better :) PTAL. Thank you!

nidhijaju avatar Aug 10 '22 11:08 nidhijaju

I'm missing a test that shows that the serialization happens on abort. I would expect something like a live JS object that increments a counter every time it's accessed. The reason observed by the SW should show a "frozen" version from when the abort took place while other callers would still get the live object.

noamr avatar Aug 15 '22 10:08 noamr

I'm missing a test that shows that the serialization happens on abort. I would expect something like a live JS object that increments a counter every time it's accessed. The reason observed by the SW should show a "frozen" version from when the abort took place while other callers would still get the live object.

Apologies for the delay! I added a test, but I'm not sure if it's exactly what you were looking for. Would you be able to take a look? Thank you!

nidhijaju avatar Aug 24 '22 06:08 nidhijaju