wpt-pr-bot icon indicating copy to clipboard operation
wpt-pr-bot copied to clipboard

Published 20 hours ago • verified publisher icon web-platform-tests

Don't assign the owner of a PR

Open foolip opened this issue 6 years ago • 3 comments

On https://github.com/web-platform-tests/wpt/pull/18677 @wpt-pr-bot assigned me even though I sent the PR. That's not very helpful.

foolip avatar Aug 27 '19 07:08 foolip

It looks like this shouldn't happen: https://github.com/web-platform-tests/wpt-pr-bot/blob/b6b7fd1efb22d63f5c94cc39e04cdbd74ac1a8ab/lib/metadata/choose-assignee.js#L16

So the question then becomes why it did. The PR was initially a draft, might that explain it?

foolip avatar Aug 27 '19 07:08 foolip

That pull request was reviewed by its author, and as per gh-55, the script assigns the latest reviewer.

That review came hours after the pull request was opened, though. So the new question is: why didn't the bot assign a reviewer initially?

It's not that the pull request was a draft since (per gh-69) we know the script responds to such events.

jugglinmike avatar Aug 27 '19 16:08 jugglinmike

Oh, I was just "reviewing" to get inline comments grouped together in a batch, I didn't even consider that activity as a review. But that explains what happened here, thanks!

foolip avatar Aug 27 '19 19:08 foolip