Unable to dismiss assignee

[zcorpan]

It seems https://github.com/web-platform-tests/wpt-pr-bot/pull/55 introduced a problem similar to https://github.com/web-platform-tests/wpt-pr-bot/issues/9 (PR https://github.com/web-platform-tests/wpt-pr-bot/pull/31)

See

https://github.com/web-platform-tests/wpt/pull/15649#event-2177970274

annevk unassigned zcorpan 2 hours ago wpt-pr-bot assigned zcorpan 2 hours ago

cc @lukebjerring

[lukebjerring]

So, while this is quite annoying, and we should change it, it's somewhat working as intended.

The current assignee for a review should not just unassign themselves, and thus ignore the PR - they are responsible for delegating the task. Just unassigning themselves (and having the bot handle that, not reassigning) will result in a PR that has no assignee, and gets neglected.

So, as expected, when you assigned foolip as the review first, then unassigned yourself, it didn't reassign you (because there's an assignee).

[jugglinmike]

@lukebjerring I think that's an good interpretation of the feature and its intended use. If there's a bug here, it's that the script is too eager, and its immediate response forces people to switch assignees in a particular order. I was going to recommend inserting a delay in order to give folks a chance to unassign and then reassign, but we already have a 5-second delay (though it's motivated by another requirement). In light of that, I don't think any change is required. What do you think?

[lukebjerring]

I'm not convinced that any changes should be made - to mitigate the nuisance would require doing something informative (maybe an instructional comment?). Are we able to temper a different delay for each hook behaviour?

[zcorpan]

A longer delay before reassigning (say 60 seconds) would be good I think. The bot could add a comment, but I think it's not necessary.