wpt-pr-bot icon indicating copy to clipboard operation
wpt-pr-bot copied to clipboard

WebKit export tool does not add wpt-pr-bot as a reviewer (but leaves a comment)

Open graouts opened this issue 10 months ago • 4 comments

I've exported a few WebKit changes to the WPT repository using the appropriate export tool (Tools/Scripts/export-w3c-test-changes) and the result has been that wpt-pr-bot leaves the "This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+." comment but is not added as a reviewer leaving the PR with no assigned reviewer. Here's the most recent example: https://github.com/web-platform-tests/wpt/pull/50756.

graouts avatar Feb 17 '25 18:02 graouts

Compare: https://github.com/web-platform-tests/wpt/pull/50755

gsnedders avatar Feb 17 '25 18:02 gsnedders

Maybe this is just another way in which https://github.com/web-platform-tests/wpt-pr-bot/issues/164 fails? I'm not sure I totally understand the code-flow here.

gsnedders avatar Feb 17 '25 18:02 gsnedders

Oh, your WebKit bug is still open, so the one situation that applies to WebKit GitHub PRs doesn't apply, therefore we don't conclude it has been reviewed yet:

https://github.com/web-platform-tests/wpt-pr-bot/blob/f03de165700a8dcb8ab47b0a15c8c0be9f083fe2/lib/metadata/webkit.js#L43-L47

I agree the state of the WPT PR could be clearer in this case, for example adding itself as a reviewer anyway.

See: https://github.com/web-platform-tests/wpt-pr-bot/blob/f03de165700a8dcb8ab47b0a15c8c0be9f083fe2/lib/comment.js#L44-L46

gsnedders avatar Feb 17 '25 19:02 gsnedders

I could be wrong, and in fact given all of the above I most likely am, but I've only noticed this recently and I've always used Tools/Scripts/export-w3c-test-changes after creating a WebKit PR, ie. when the bugzilla bug is very much open.

graouts avatar Feb 18 '25 07:02 graouts