wpt-metadata icon indicating copy to clipboard operation
wpt-metadata copied to clipboard

Normalize META.yml indentation

Open foolip opened this issue 4 years ago • 4 comments

When working on https://github.com/web-platform-tests/wpt-metadata/pull/2196+https://github.com/web-platform-tests/wpt-metadata/pull/2208 I noticed different indentation in different files, which made it harder to work with the files.

Could we normalize the formatting of META.yml files and enforce that formatting in the lint?

@KyleJu WDYT?

P.S. I thought there was already an issue about this but I couldn't find it. Sorry if it is nevertheless a dupe of some existing issue.

foolip avatar Nov 24 '21 12:11 foolip

Yea I think there was issue where PRs create huge diff after the indentation changes. https://github.com/web-platform-tests/wpt-metadata/pull/2207 all the gecko updates have less indentation than the default one. Let me find a way to enforce the format in the lint

KyleJu avatar Nov 24 '21 20:11 KyleJu

Oh, does the Gecko sync bot not use the API for updating metadata then?

foolip avatar Nov 25 '21 09:11 foolip

Oh, does the Gecko sync bot not use the API for updating metadata then?

nope I think they use a separate script. I am unsure what YAML library they use, which leads to a difference in formatting

KyleJu avatar Nov 25 '21 22:11 KyleJu