interop icon indicating copy to clipboard operation
interop copied to clipboard

[css-properties-values-api] Test coverage for "<string>" component name

Open zrhoffman opened this issue 1 year ago • 13 comments

Test List

Test <string> test coverage PR
https://wpt.live/css/css-properties-values-api/at-property.html web-platform-tests/wpt#43757
https://wpt.live/css/css-properties-values-api/register-property-syntax-parsing.html web-platform-tests/wpt#41308

Rationale

A css-properties-values-api editor accepted a proposal to add the "<string>" component name in w3c/css-houdini-drafts#1103. Once the spec is updated, this new syntax component name will need WPT coverage.

zrhoffman avatar Aug 03 '23 13:08 zrhoffman

sgtm

lilles avatar Aug 03 '23 13:08 lilles

Seems ok, although note that this is CSS.registerProperty() not @property

nt1m avatar Aug 09 '23 05:08 nt1m

I would want the spec PR to be merged before merging the WPT PR fwiw.

nt1m avatar Aug 09 '23 05:08 nt1m

Seems ok, although note that this is CSS.registerProperty() not @property

Yes, we should add tests for <string> here too: http://wpt.live/css/css-properties-values-api/at-property.html

I would want the spec PR to be merged before merging the WPT PR fwiw.

Yes, that's why I blocked https://github.com/web-platform-tests/wpt/pull/41308

lilles avatar Aug 09 '23 09:08 lilles

https://wpt.fyi/results/css/css-properties-values-api/register-property-syntax-parsing.html?label=experimental&label=master&aligned is now fully passing in all browsers.

The practical benefit of including it now is very low, but also fine if we can get the spec PR merged and signoff from Mozilla here before EOY.

foolip avatar Dec 20 '23 16:12 foolip

Seems ok, although note that this is CSS.registerProperty() not @property

Yes, we should add tests for <string> here too: http://wpt.live/css/css-properties-values-api/at-property.html

Tests added in web-platform-tests/wpt#43757.

zrhoffman avatar Dec 20 '23 18:12 zrhoffman

https://wpt.fyi/results/css/css-properties-values-api/register-property-syntax-parsing.html?label=experimental&label=master&aligned is now fully passing in all browsers.

The practical benefit of including it now is very low, but also fine if we can get the spec PR merged and signoff from Mozilla here before EOY.

cc: @emilio

zrhoffman avatar Dec 20 '23 18:12 zrhoffman

Sounds good to me.

emilio avatar Dec 20 '23 18:12 emilio

https://github.com/w3c/css-houdini-drafts/issues/1103 has still not been merged and Interop 2023 is now closed and the dashboard isn't being updated. I'll close this, but someone please reopen if we should do something retroactively here.

foolip avatar Mar 12 '24 14:03 foolip

w3c/css-houdini-drafts#1103 has still not been merged and Interop 2023 is now closed and the dashboard isn't being updated. I'll close this, but someone please reopen if we should do something retroactively here.

@foolip The Custom Properties focus area is carried over from Interop 2023 to Interop 2024, so #389 should probably stay open.

zrhoffman avatar Mar 12 '24 23:03 zrhoffman

@zrhoffman sorry, my bad!

foolip avatar Mar 13 '24 06:03 foolip

https://github.com/w3c/css-houdini-drafts/pull/1104 is the PR for this change that we should keep an eye on.

foolip avatar Apr 04 '24 16:04 foolip

The spec is updated. WPT PRs needing review: web-platform-tests/wpt#43757, web-platform-tests/wpt#41308

zrhoffman avatar Apr 11 '24 00:04 zrhoffman

Closing #389 because web-platform-tests/wpt#43757 and web-platform-tests/wpt#41308 are merged. Thanks all! :)

zrhoffman avatar Aug 05 '24 16:08 zrhoffman