Serhii Kulykov

Results 357 comments of Serhii Kulykov

One thing to consider is that navigation should probably still point to the correct page, see the example: ![notfound](https://user-images.githubusercontent.com/10589913/88288216-1dae2b80-ccfc-11ea-9853-7c0c6eb7a346.png) As you can see, unlike the real 404 page, user still...

Thanks for the issue. Related feature request for adding more Lumo colors: #3330

Here are some more flaky tests from the recent coverage builds (failed in Chrome): ### date-picker ``` packages/date-picker/test/scroller.test.js: ❌ vaadin-infinite-scroller > should reflect currently visible item index as position scrolling...

Fixing this would require a breaking change as it would break users who apply styles using light DOM in their `styles.css`: ```css vaadin-checkbox { /* custom styles */ } vaadin-grid...

Actually, we might want to remove these styles altogether, since the font-size has been added in #2746: https://github.com/vaadin/web-components/blob/4fb709e15e78a2e1d12c7f38e5a28bfa7f028442/packages/checkbox/theme/lumo/vaadin-checkbox-styles.js#L14

Similar issue reported [internally](https://vaadin.slack.com/archives/C3TGRP4HY/p1657613577164119) from a user with Chromebook (could be Linux specific): > I have an issue when using Chrome (Version 103.0.5060.114). The values of an input field will...

Note, at least `lit` should not be removed because it's present in `NodeUpdater`. https://github.com/vaadin/flow/blob/7cab180688c94fdf2a471249b150ae8531b73a93/flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java#L368 I think the fact that manually added dependencies get removed is a known problem.

> user has set a package that at some point becomes the same as the Vaadin version at which point it becomes FW handled BTW this is the case for...

@Juchar thanks for the suggestion. That's something worth considering. One concern is that I'm not sure how well does it fit Material guidelines. There is a [Toggle button](https://material.io/design/components/buttons.html#toggle-button) concept but...

This is not currently prioritised. Also, the teleportation logic is a bit awkward at the moment. We might change that in future while migrating to LitElement so implement that in...