web-infra-dev
fix(DOM): change DOM selector from root to __rspress_root (#2419)
Summary
Related Issue
#2419
Checklist
- [ ] Tests updated (or not required).
- [ ] Documentation updated (or not required).
Deploy Preview for rspress-v2 ready!
| Name | Link |
|---|---|
| Latest commit | 71f1269cd5e3ebccdbe21fe74935d34e633d9e99 |
| Latest deploy log | https://app.netlify.com/projects/rspress-v2/deploys/6894c92262177e00083fb857 |
| Deploy Preview | https://deploy-preview-2450--rspress-v2.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for rspress ready!
| Name | Link |
|---|---|
| Latest commit | 71f1269cd5e3ebccdbe21fe74935d34e633d9e99 |
| Latest deploy log | https://app.netlify.com/projects/rspress/deploys/6894c922d24861000827cd59 |
| Deploy Preview | https://deploy-preview-2450--rspress.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 85 (🔴 down 9 from production) Accessibility: 97 (no change from production) Best Practices: 92 (🟢 up 9 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify project configuration.
Sorry for the late reply, this is a breaking change, which affects users who use CSS #root selector to override Rspress default-theme styles.
I plan to combine it with the other theme style update release, otherwise, it may have some impact on users.
Sorry for the late reply, this is a breaking change, which affects users who use CSS #root selector to override Rspress default-theme styles.
I plan to combine it with the other theme style update release, otherwise, it may have some impact on users.
I understand. I expect this change could have a significant impact, so please feel free to roll it out gradually.
thanks, done in https://github.com/web-infra-dev/rspress/issues/2533 and 2.0.0-rc.0