rspack icon indicating copy to clipboard operation
rspack copied to clipboard

fix: compiler js object cannot be gc

Open SyMind opened this issue 8 months ago • 2 comments

Summary

Compiler is unable to GC due to some ThreadsafeFunctions, which include

  1. hooks callback
  2. run_loaders

The solution is to strictly drop these ThreadsafeFunctions at the end of the build.

Checklist

  • [ ] Tests updated (or not required).
  • [ ] Documentation updated (or not required).

SyMind avatar Mar 14 '25 23:03 SyMind

Deploy Preview for rspack canceled.

Name Link
Latest commit bf71d2a0cc755ce4851a0f6f0afac6cfb19eb0a5
Latest deploy log https://app.netlify.com/sites/rspack/deploys/680ddacdda774700080b3030

netlify[bot] avatar Mar 14 '25 23:03 netlify[bot]

CodSpeed Performance Report

Merging #9685 will not alter performance

Comparing fix-js-object-gc (bf71d2a) with main (b8c8945)

:tada: Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability :partying_face:! Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

codspeed-hq[bot] avatar Mar 15 '25 00:03 codspeed-hq[bot]