rspack icon indicating copy to clipboard operation
rspack copied to clipboard

Draft: add AMD dependencies

Open nilptr opened this issue 1 year ago • 2 comments

Summary

add AMD dependencies for #4313.

Checklist

  • [ ] Tests updated (or not required).
  • [ ] Documentation updated (or not required).

nilptr avatar Aug 19 '24 14:08 nilptr

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
Latest commit 57377e13c374ca14fe5722953a72150554d8d457
Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f0cd799ed4e000084693d7
Deploy Preview https://deploy-preview-7612--rspack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 19 '24 14:08 netlify[bot]

@nilptr you need review advice, please ping us

hardfist avatar Sep 17 '24 14:09 hardfist

Hello, is this still in progress?

SoonIter avatar Oct 08 '24 03:10 SoonIter

@nilptr Do you need help ? This PR has not made progress in a long time.

GiveMe-A-Name avatar Nov 01 '24 07:11 GiveMe-A-Name

hihi @GiveMe-A-Name sorry for late reply. I was busy with my job, didn't check github. Actually, I started a new branch, and this branch is discard. Let me close this PR and create a new one for review.

Currently, I have finished the AMDDefineDependencyParserPlugin and AMDRequireDependenciesBlockParserPlugin, and added test cases for them. So far they seem to work well. But I still need more time (maybe 1or2 weeks) to do some integration. I will discuss the details with you guys this week. cc: @ahabhgk

Thank you.

nilptr avatar Nov 10 '24 16:11 nilptr