rspack
rspack copied to clipboard
web-infra-dev
[Feature]: builtin-lightningcss-loader add support for `visitor` option
What problem does this feature solve?
https://rspack.dev/zh/guide/features/builtin-lightningcss-loader#options https://lightningcss.dev/transforms.html
What does the proposed API of configuration look like?
LightningcssLoaderOptions 增加 visitor
It's cool but not that high priority for us at present, and if using JavaScript visitor, there will be interop between Rust and JavaScript, so the performance gain of builtin-loader is gone, in this case you can try calling lightningcss-node binding yourself, or you can try this loader from community
We will support visitors in the future, but still, not high priority for us at present, of course we are happy to help if you are willing to contribute for this feature
Without visitor, from a business perspective, built-in functions are useless, such as px to vw, etc.
https://empjs.dev/plugin/tool/plugin-lightningcss.html At present, the processing method of postcss has been rewritten. I just want to switch to the built-in function, but the gap is a bit big
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!
No progress temporarily, we will do this in two week recently.
Really looking forward
guys, if there's any news on this feature, we have 80 percent of the build taken up by postcss plugins on our project, we want to switch to lightningcss. Sincerely, a dedicated rspack user
consider visitor will cause lots of rust <-> js commutation which will make builtin-lightningcss-loader slow, we suggest use the js version of lightningcss-loader instead if you want to use lightningcss with visitor
