rspack icon indicating copy to clipboard operation
rspack copied to clipboard

fix: should insert semi after import, export, debugger and class field

Open CPunisher opened this issue 1 year ago • 1 comments

Summary

Checklist

ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#automatic_semicolon_insertion and acorn (search this.semicolon())

But I dont know how to construct the test case for ClassField

closes https://github.com/web-infra-dev/rspack/issues/7527

  • [ ] Tests updated (or not required).
  • [ ] Documentation updated (or not required).

CPunisher avatar Aug 11 '24 10:08 CPunisher

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
Latest commit f2b84a0aa85f72530c1b7c48f55c24f821b2bf56
Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b9c65df338270008b13b34

netlify[bot] avatar Aug 11 '24 10:08 netlify[bot]

Would you please fix the CI?

h-a-n-a avatar Aug 12 '24 04:08 h-a-n-a

Would you please fix the CI?

There are ci errors on the main branch, where the latest commits also failed. ☹️

CPunisher avatar Aug 12 '24 04:08 CPunisher

Would you please fix the CI?

There are ci errors on the main branch, where the latest commits also failed. ☹️

I see. Let's wait for a fix of the main branch then.

h-a-n-a avatar Aug 12 '24 04:08 h-a-n-a

let's see if #7534 fixes ci

JSerFeng avatar Aug 12 '24 08:08 JSerFeng

let's see if #7534 fixes ci

Looks like it did ;-)

h-a-n-a avatar Aug 12 '24 08:08 h-a-n-a