rspack icon indicating copy to clipboard operation
rspack copied to clipboard

[Bug]: webpack-workbox-plugin not working with rspack

Open saifislamrepos opened this issue 9 months ago • 4 comments

System Info

node 20 react 18 "workbox-webpack-plugin": "^7.1.0"

Details

webpack-workbox plugin is giving error on rspack build ERROR in × TypeError: Cannot read properties of undefined (reading 'source') │ at InjectManifest.addAssets node_modules/workbox-webpack-plugin/build/inject-manifest.js:223:39

ERROR in × Error: × TypeError: Cannot read properties of undefined (reading 'set') │ │ at Object.fn ** /node_modules/webpack/lib/EntryPlugin.js:37:37

Reproduce link

No response

Reproduce Steps

add const { InjectManifest } = require('workbox-webpack-plugin'); in your build config will give trigger above error in build process

saifislamrepos avatar May 04 '24 12:05 saifislamrepos

Please try to use inject-manifest-plugin instead

LingyuCoder avatar May 06 '24 03:05 LingyuCoder

Please try to use inject-manifest-plugin instead

I'm not sure but the library you introduced really has too few uses. I'm more familiar with using workbox-webpack-plugin and its strong community!!! Will you support integrating this plugin into rspack?

nguyenbatranvan avatar May 07 '24 13:05 nguyenbatranvan

Please try to use inject-manifest-plugin instead

I'm not sure but the library you introduced really has too few uses. I'm more familiar with using workbox-webpack-plugin and its strong community!!! Will you support integrating this plugin into rspack?

This is an InjectManifest implementation compatible with Rspack. It is based on the original plugin and is compatible with the Rspack API. This plugin is currently contributed by the community and will not be integrated into rspack internally. If you encounter any issues, you can directly submit an issue or pull request to it.

LingyuCoder avatar May 15 '24 03:05 LingyuCoder

Please try to use inject-manifest-plugin instead

I'm not sure but the library you introduced really has too few uses. I'm more familiar with using workbox-webpack-plugin and its strong community!!! Will you support integrating this plugin into rspack?

This is an InjectManifest implementation compatible with Rspack. It is based on the original plugin and is compatible with the Rspack API. This plugin is currently contributed by the community and will not be integrated into rspack internally. If you encounter any issues, you can directly submit an issue or pull request to it.

yess!! have some issue with plugin!! i suggest use workbox-rspack-plugin!! This plugin work well

nguyenbatranvan avatar May 15 '24 05:05 nguyenbatranvan