rspack icon indicating copy to clipboard operation
rspack copied to clipboard

Builtin progress bar is broken when using multi compiler

Open chenjiahan opened this issue 2 years ago • 6 comments

System Info

System: OS: macOS 13.5.2 CPU: (10) arm64 Apple M1 Pro Memory: 375.17 MB / 32.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 16.18.0 - ~/Library/Caches/fnm_multishells/41106_1695025348387/bin/node npm: 8.19.2 - ~/Library/Caches/fnm_multishells/41106_1695025348387/bin/npm Browsers: Chrome: 116.0.5845.187 Safari: 16.6 npmPackages: @rspack/cli: workspace:* => 0.3.4

Details

When there are multiple compilers, the builtin progress bar can not render as expected. The two bars overlap instead of being rendered separately:

Screenshot 2023-09-18 at 19 05 14

Reproduce link

https://github.com/web-infra-dev/rspack/tree/main/examples/basic

Reproduce Steps

  1. cd examples/basic
  2. add following configs:
/** @type {import('@rspack/cli').Configuration} */

module.exports = [
  {
    name: "Client",
    context: __dirname,
    mode: "development",
    entry: {
      main: "./src/index.js"
    }
  },
  {
    name: "Server",
    target: "node",
    context: __dirname,
    mode: "development",
    entry: {
      main: "./src/index.js"
    }
  }
];
  1. pnpm run dev

chenjiahan avatar Sep 18 '23 11:09 chenjiahan

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Dec 29 '23 07:12 stale[bot]

bump

chenjiahan avatar Dec 29 '23 07:12 chenjiahan

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Feb 27 '24 08:02 stale[bot]

bump

chenjiahan avatar Feb 27 '24 08:02 chenjiahan

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Apr 27 '24 08:04 stale[bot]

bump

chenjiahan avatar Apr 27 '24 08:04 chenjiahan

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Jun 26 '24 08:06 stale[bot]

the current hooks seems enough for a progressbar implementation it's just the current progress bar implementation maybe too complex and calls too much hook

hardfist avatar Aug 13 '24 04:08 hardfist