rspack icon indicating copy to clipboard operation
rspack copied to clipboard

Support aliased resolving

Open h-a-n-a opened this issue 2 years ago • 12 comments

          Currently, Due to the fact that nodejs-resolver does not support resolving with alias, Rspack does not support resolve aliased loader. We should fix this.

Originally posted by @h-a-n-a in https://github.com/web-infra-dev/rspack/pull/4008#discussion_r1301293077

h-a-n-a avatar Aug 22 '23 08:08 h-a-n-a

@Boshen can verify whether is resolved?

hardfist avatar Sep 08 '23 13:09 hardfist

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Nov 07 '23 15:11 stale[bot]

Where are the tests for "resolve aliased loader"? Let's try and turn them on so we can close this issue.

Boshen avatar Nov 08 '23 02:11 Boshen

Where are the tests for "resolve aliased loader"? Let's try and turn them on so we can close this issue.

@Boshen try turn on this for oxc resolver https://github.com/web-infra-dev/rspack/pull/4008/files#diff-cd6dcd934ac301a223707a61b3bba520be1c3ee63a00ba24e6cbe8bb79ccf266R6, I think this is used to test agains alias with query case(which is not supported in the old nodejs_resolver), cc @h-a-n-a

hardfist avatar Nov 08 '23 03:11 hardfist

@h-a-n-a This PR from webpack indicates that this should be solved on the Rspack side?

https://github.com/webpack/webpack/pull/3445/files#diff-d73b6d4cb18e533b6d82864565571fb5d0b87455a67503db7464eff699bfea1a

Boshen avatar Dec 08 '23 08:12 Boshen

So this is about the alias option in the config, right?

It does compile with aliases, but re-compilation on file changes doesn't work if the file path is imported via alias. Is this the correct issue for this problem, and are there any news on this?

Narretz avatar Jan 24 '24 05:01 Narretz

So this is about the alias option in the config, right?

It does compile with aliases, but re-compilation on file changes doesn't work if the file path is imported via alias. Is this the correct issue for this problem, and are there any news on this?

@Narretz I assume this is a different issue than this one, would you please create another issue?

h-a-n-a avatar Feb 02 '24 05:02 h-a-n-a

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Apr 02 '24 05:04 stale[bot]

I believe it's still not clear if everything related to Alias Resolving is tested correctly.

Narretz avatar Apr 07 '24 11:04 Narretz

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Jun 06 '24 14:06 stale[bot]

bump

h-a-n-a avatar Jun 11 '24 18:06 h-a-n-a

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

stale[bot] avatar Aug 10 '24 19:08 stale[bot]

bump

hardfist avatar Aug 16 '24 06:08 hardfist