rspack icon indicating copy to clipboard operation
rspack copied to clipboard

chore(cli): mode default config by process.env.NODE_ENV

Open SoonIter opened this issue 2 years ago • 1 comments

Summary

  • auto set "mode" by NODE_ENV, remove the hardcoded config
  • extract "buildConfig" method

Related issue (if exists)

closes #2280

Types of changes

  • [ ] Docs change / Dependency upgrade
  • [ ] Bug fix
  • [x] New feature / Improvement
  • [x] Refactoring
  • [ ] Breaking change

Checklist

  • [x] I have added changeset via pnpm run changeset.
  • [x] I have added tests to cover my changes.

SoonIter avatar Mar 19 '23 08:03 SoonIter

🦋 Changeset detected

Latest commit: 9db25ff566668e11feb4e0b13e641b1c88ad0dfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/cli Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 19 '23 08:03 changeset-bot[bot]

@h-a-n-a cc

SoonIter avatar Mar 21 '23 07:03 SoonIter

LGTM, I will merge it after resolved conflicts

jerrykingxyz avatar Mar 23 '23 10:03 jerrykingxyz