rspack icon indicating copy to clipboard operation
rspack copied to clipboard

perf(rspack_core): remove unnecessary `par_iter` from remove_parent_modules

Open Boshen opened this issue 2 years ago • 1 comments

Summary

Creating parallel iterators on tight cpu loops with closer to cpu memory is useless here, removing these does not affect performance.

Related issue (if exists)

Types of changes

  • [ ] Docs change / Dependency upgrade
  • [ ] Bug fix
  • [x] New feature / Improvement
  • [ ] Refactoring
  • [ ] Breaking change

Checklist

  • [ ] I have added changeset via pnpm run changeset.
  • [ ] I have added tests to cover my changes.

Boshen avatar Mar 16 '23 08:03 Boshen

⚠️ No Changeset found

Latest commit: 76ab1f91643bbfda867f4ae5ce11dbd5162d0dfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 16 '23 08:03 changeset-bot[bot]