modern.js
modern.js copied to clipboard
[Bug]: Minor inconsistency in MFE Guides
Version
System:
OS: macOS 13.5.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 46.62 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Browsers:
Chrome: 126.0.6478.127
Safari: 17.4.1
npmPackages:
@modern-js/app-tools: 2.55.0 => 2.55.0
@modern-js/eslint-config: 2.55.0 => 2.55.0
@modern-js/plugin-garfish: 2.55.0 => 2.55.0
@modern-js/runtime: 2.55.0 => 2.55.0
@modern-js/tsconfig: 2.55.0 => 2.55.0
Details
Hi, in micro-frontend guides here https://modernjs.dev/en/guides/topic-detail/micro-frontend/c02-development.html We can see
runtime: {
router: true,
state: true,
masterApp: true,
},
but accepted types for masterApp is RuntimeUserConfig.masterApp?: Config | undefined
Options: 1 Changing guides to reflect new changes 2 Extend accepted types to prevent this inconsistency
I can create a PR with a fixed one once we agree what is the best option.
Reproduce link
https://github.com/kirillbashtenko/modern-js-example
Reproduce Steps
1 pnpm install 2 open modern.config.ts