modern.js
modern.js copied to clipboard
[Bug]: MFE examples not working with the latest react-router
Version
System:
OS: macOS 13.5.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 1.52 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Browsers:
Chrome: 120.0.6099.199
Safari: 16.6
npmPackages:
@modern-js/app-tools: 2.45.0 => 2.45.0
@modern-js/builder-rspack-provider: 2.45.0 => 2.45.0
@modern-js/eslint-config: 2.45.0 => 2.45.0
@modern-js/plugin-garfish: 2.45.0 => 2.45.0
@modern-js/runtime: 2.45.0 => 2.45.0
@modern-js/tsconfig: 2.45.0 => 2.45.0
Details
I've noticed that with the latest versions of modern.js MFE examples not working anymore, it might not be directly modern.js issue, but I'm not sure. So If we try to navigate to /dashboard in the provided example we get 404 not match, it worked until the changes were introduced in [email protected] where react-router was upgraded. I read the changelogs for react-router, but haven't found anything that should break things... If I override react-router it works:) but I;m just treating the symptoms... Looking forward to any help, thanks!
"pnpm": {
"overrides": {
"react-router-dom": "6.10.0"
}
}
Reproduce link
https://github.com/kirillbashtenko/modern-js-example
Reproduce Steps
1 pnpm install 2 pnpm start 3 cd dashboard 4 pnpm install 5 pnpm start